search

khaeru / sdmx

SDMX information model and client in Python
https://sdmx1.readthedocs.io
Apache License 2.0
23 stars 17 forks source link

Handle quirks of ESTAT-operated sources COMP, EMPL, GROW #163

Closed khaeru closed 4 months ago

khaeru commented 5 months ago

Closes #162.

Note that this PR does not address this TODO: https://github.com/khaeru/sdmx/blob/7a2de97237860eac894399fd8c4cba9e09180234/sdmx/client.py#L279-L283 …as a consequence, some of the code in .source.estat.handle_references_param() is duplicative of existing code in Client._handle_get_kwargs(). The Source class will get a more extensive rework soon, in which this duplication can probably be removed.

PR checklist

codecov[bot] commented 5 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7a2de97) 98.72% compared to head (13bf7ed) 96.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #163 +/- ## ========================================== - Coverage 98.72% 96.41% -2.31% ========================================== Files 87 90 +3 Lines 7055 7085 +30 ========================================== - Hits 6965 6831 -134 - Misses 90 254 +164 ``` | [Files](https://app.codecov.io/gh/khaeru/sdmx/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto) | Coverage Δ | | |---|---|---| | [sdmx/tests/test\_docs.py](https://app.codecov.io/gh/khaeru/sdmx/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC90ZXN0cy90ZXN0X2RvY3MucHk=) | `100.00% <ø> (ø)` | | | [sdmx/tests/test\_sources.py](https://app.codecov.io/gh/khaeru/sdmx/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC90ZXN0cy90ZXN0X3NvdXJjZXMucHk=) | `67.69% <ø> (-27.70%)` | :arrow_down: | | [sdmx/source/comp.py](https://app.codecov.io/gh/khaeru/sdmx/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC9zb3VyY2UvY29tcC5weQ==) | `71.42% <71.42%> (ø)` | | | [sdmx/source/empl.py](https://app.codecov.io/gh/khaeru/sdmx/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC9zb3VyY2UvZW1wbC5weQ==) | `71.42% <71.42%> (ø)` | | | [sdmx/source/estat.py](https://app.codecov.io/gh/khaeru/sdmx/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC9zb3VyY2UvZXN0YXQucHk=) | `62.29% <88.88%> (-30.02%)` | :arrow_down: | | [sdmx/source/grow.py](https://app.codecov.io/gh/khaeru/sdmx/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC9zb3VyY2UvZ3Jvdy5weQ==) | `71.42% <71.42%> (ø)` | | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/khaeru/sdmx/pull/163/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto)
khaeru commented 4 months ago

The codecov/patch check failure here is expected: there were added lines in data source tests that are not run on every PR commit, but only on main on a schedule trigger. These should be run the first time that happens after the PR is merged.