search

khairul169 / gdsqlite-native

SQLite module for Godot 3.x
MIT License
219 stars 41 forks source link

Added BLOB data support, rewrote argument binding #42

Open TGRCdev opened 4 years ago

TGRCdev commented 4 years ago

This pull request changes how arguments are bound for queries, allowing for Variant types like PoolByteArrays to be bound to BLOB-type columns. It also adds the ability to retrieve BLOB types from databases as a PoolByteArray.

The side effect of this is that any *_with_args command will only accept an Array containing the following Variant types:

This pull request has been tested on Windows 10 64-bit, using Godot 3.1.1 stable.

Closes #41.

fire commented 4 years ago

Do you know if khairul169 is still in the community?

Also, would it be better if this was a c++ module? I could do the work for it, but I don't think it'll get merged into master.

TGRCdev commented 4 years ago

Khairul is still active on Github, but I haven't seen activity from them in the gdsqlite-native repository in a while. I may ask to take over as the maintainer of the repo if they're ok with it.

There was some talk about integrating SQLite into Godot's core, but the devs decided that it would be better handled as an optional community module.

I could bring back the engine module for platforms without proper working GDNative exports (iOS), but I'd want to integrate both module forms into a single repository. I don't want to copy changes from one repo into another.

fire commented 4 years ago

I don't know how to support both forms in the same repository.

Maybe you can have the central repository be the module and include the GDnative machinery under it. The other way doesn't work.

fire commented 4 years ago

By the way, I'm a part of https://github.com/godot-extended-libraries. Perhaps that would be helpful for advertising and pooling resources to put this gdsqlite-native library there?

@khairul169 Can you respond?

fire commented 4 years ago

@TGRCdev I ported the code to a Godot Engine module. However, I wanted to ping you before merging this patch too.

Ping me or @willnationsdev for Github access.

fire commented 4 years ago

Here's the link.

https://github.com/godot-extended-libraries/godot-sqlite

TGRCdev commented 4 years ago

@fire Sure, I'd be glad to help maintain it.

The repo should only contain the engine module, though. Most people who'd use an engine module would already have Godot's source repo cloned, so having Godot's source in the module's repo is redundant.

fire commented 4 years ago

@TGRCdev Updated, and feel free to add yourself to the authors.