search

khaled-0 / TubeSync

Sync YouTube playlists offline. Because YT Music is too costly
GNU General Public License v3.0
70 stars 5 forks source link

iOS integration #2

Open durul opened 1 week ago

khaled-0 commented 1 week ago

You just ran flutter create --platform=ios

I am not adding ios support because I don't have an iOS device to build/test app right now.

So unfortunately, I don't think this PR will work out for now. Thanks for your time though.

durul commented 1 week ago

You just ran flutter create --platform=ios

I am not adding ios support because I don't have an iOS device to build/test app right now.

So unfortunately, I don't think this PR will work out for now. Thanks for your time though.

Simulator Screen Recording - iPhone 16 - 2024-11-10 at 11 26 38

khaled-0 commented 1 week ago

It's good to see that everything "probably" works. However there's some extra ios related setups for some dependencies. Could you please also look into those. e.g the launcher icons/native splash/notification/media playback etc. Also remove the placeholder test as I have yet to implement unit tests.

And then there's the ci/cd

durul commented 1 week ago

It's good to see that everything "probably" works. However, there are some extra iOS-related setups for some dependencies. Could you please also look into those, e.g., the launcher icons/native splash/notification/media playback, etc.? Also, remove the placeholder test, as I have yet to implement unit tests.

And then there's the ci/cd

✅ remove the placeholder test, as I have yet to implement unit tests. ✅ Ci/Cd conflict fixed

I looked at the dependencies, but I couldn't see any extra ones. Also, some assets were added automatically for iOS by the Flutter generator.

Can you please point out specific concerns about which dependencies and setups?

khaled-0 commented 1 week ago

Can you please point out specific concerns about which dependencies and setups?

Well I can't exactly point out. If it works for you then it's all good for now ig. I'll get to it as soon as I'm done with linux & fdroid

thanks btw

khaled-0 commented 1 week ago

hey, I think we're ready to merge this before that could you please add launcher icons and native splash in the corresponding files used by android. I'll take care of the ci/cd afterwards

khaled-0 commented 1 week ago

Also I don't have an apple dev account (obviously) so I'll be following these https://filippovalle.medium.com/how-to-create-a-ipa-file-in-flutter-without-signin-70e9c6a2087f https://filippovalle.medium.com/the-alternative-stores-thanks-to-eu-a6bfc6a09675

khaled-0 commented 1 week ago

btw also try this using AltStore https://nightly.link/khaled-0/TubeSync/actions/runs/11821248584/tubesync_ios_nightly.zip need to confirm CI works