Open GoogleCodeExporter opened 9 years ago
Original comment by q3a...@gmail.com
on 16 Apr 2012 at 2:45
Original comment by q3a...@gmail.com
on 19 Apr 2012 at 11:11
This issue was updated by revision r182.
Removed a IsSolvable() call that would boost the performance
Original comment by q3a...@gmail.com
on 20 Apr 2012 at 7:33
This issue was updated by revision r191.
added a "-" sign that was , unintentionally, missed in case negativeLMass
Original comment by q3a...@gmail.com
on 20 Apr 2012 at 9:28
https://cacoo.com/diagrams/JPiKr6qMtGsgcK0n
https://cacoo.com/diagrams/zJUZw9zha0E4lPK9
links for the Design(NOT READY)
Original comment by q3a...@gmail.com
on 20 Apr 2012 at 10:01
This issue was updated by revision r230.
removed some useless comments(they were reminders for me to discuss stuff with
my team during a meeting) and modified the commented lines to work according to
what was discussed in the meeting today. Method will be uncommented when all
the methods it uses are implemented.
update issue 98
Status: New
modified names according to last renames
Original comment by q3a...@gmail.com
on 21 Apr 2012 at 5:55
This issue was updated by revision r236.
Updated Documentation according to latest changes
Updated Small problem with the method
Changed the name to be more descriptive of what exactly the method does
update issue 99
Status: New
modified names according to last renames
update issue 100
Status: New
modified method header and parameters according to last renames
Original comment by q3a...@gmail.com
on 21 Apr 2012 at 7:13
update issue 19
Status: In Progress
issue 16 was a typo it's an update for issue 19
Original comment by q3a...@gmail.com
on 21 Apr 2012 at 7:17
This issue was updated by revision r242.
Updated Documentation: Added author to documentation in my methods
Original comment by q3a...@gmail.com
on 21 Apr 2012 at 8:05
This issue was updated by revision r249.
renamed getBallFinalPosition to ballFinalPosition according to the helper
method in r248
Original comment by q3a...@gmail.com
on 21 Apr 2012 at 10:20
This issue was updated by revision r257.
Finally uncommented the commented line because the helper method was
successfully implemented according to issue 123.
Fixed a typo
mixVelocityZ and mixVelocityY renamed to minVelocityZ and minVelocityY
Original comment by q3a...@gmail.com
on 22 Apr 2012 at 10:53
Original comment by q3a...@gmail.com
on 22 Apr 2012 at 3:07
Original comment by q3a...@gmail.com
on 22 Apr 2012 at 11:41
This issue was updated by revision r309.
Removed some comments that were kept as a reminder for me.
Improved the documentation
Original comment by q3a...@gmail.com
on 23 Apr 2012 at 9:06
Original comment by q3a...@gmail.com
on 23 Apr 2012 at 9:34
This issue was updated by revision r314.
Modified the code to follow some conventions
Original comment by q3a...@gmail.com
on 23 Apr 2012 at 9:40
Original comment by q3a...@gmail.com
on 23 Apr 2012 at 7:09
This method verifies wether a method is solvable or not
Spelling mistake.
Original comment by ams.sa...@gmail.com
on 24 Apr 2012 at 8:04
Documentation lacks "."'s/periods/full-stops or whatever you want to call them.
Original comment by ams.sa...@gmail.com
on 24 Apr 2012 at 8:05
Retuns an int that represents the type of the problem with the experiment
Spelling mistake. Please use a spell checker on your documentation. Also I find
it rather vague, I'd say something like "represents the type of the problem
which caused the experiment to be unsolvable" or something like that.
Original comment by ams.sa...@gmail.com
on 24 Apr 2012 at 8:11
"Generates a solvable experiment by modifying the auto-generated givens."
"the auto-generated givens" is rather vague.
Original comment by ams.sa...@gmail.com
on 24 Apr 2012 at 8:12
I am not required to find out how to use your code, and you should provide me
with a way. This is what Ghoroury said both when I asked him in person and in
the mail attached.
Original comment by ams.sa...@gmail.com
on 25 Apr 2012 at 10:45
Attachments:
as for the way, just call GenerateSolvable()
after
Hole, Ball, User3, wind, friction are initialized.
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 4:05
Although none of this is part of my job: I tested it with dummy inputs,
apparently it goes into an infinite loop. I made the hole position at (15,0,15)
and the initial position at (10,0,10). I debugged the code, it reaches a line
"if (hole.Position.Z - user.ShootingPosition.Z > 0)" finds it true and enters
the then "return Constants3.negativeHPosZ;" then goes to the switch statement
in generateSolvable, jumps to the end of it and back to the do while loop, then
simply keeps repeating this exact loop.
Original comment by ams.sa...@gmail.com
on 25 Apr 2012 at 10:12
This issue was updated by revision r534.
Fixed.
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 10:26
and thanks for the debugging ;)
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 10:26
This issue was updated by revision r502.
the log message contained issue 14 instead of this issue by wrong. Updated
documentation
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 10:30
You did not fix all the mistakes I pointed out in the documentation.
Original comment by ams.sa...@gmail.com
on 25 Apr 2012 at 10:55
I got another infinite loop when testing with different inputs. Did you even
test your code? The first 2 (and only 2) inputs I tried gave me infinite loops.
I'm supposed to be reviewing scenarios, not debugging your code. Please do not
make it scenario ready until you test it all, and finish debugging it.
Original comment by ams.sa...@gmail.com
on 25 Apr 2012 at 10:59
which documentation comments are not yet done? i can't find any, i did all the
ones i noticed.
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 11:05
You totally ignored comments 19 and 20. Also the problem in comment 19 is
common throughout all of your documentation and you seem to be ignoring it
everywhere.
"Generates a solvable experiment." Is that what it does? What I understand (I
could very much be wrong though) is that it makes sure the experiment is
solvable, and if it isn't, the method changes the preset values to make it
solvable. If I am correct, please modify it to better describe the method.
Original comment by ams.sa...@gmail.com
on 25 Apr 2012 at 11:19
@comment 19 i believe i've fixed most of my documentation and theres only 1
missing period that i just noticed now, ill add it later.
@comment 20 i believe this explanation just simply explains what the method
does exactly, it generates a solvable experiment.
@comment 29 this is most likely because the Constants in the Constants3 class
are unitialized(like max velocity and min velocity and such variables), which i
use in my code and we should all check those in a meeting to find the correct
values for these constants
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 11:28
I believe i was correct about comment 29, i 've entered dummy values and it
doesn't go into an infinite loop..
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 11:45
didn't*
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 11:49
This issue was updated by revision r538.
changed the condition back to old state as there seems to be a misconception.
@comment 24, i considered that the hole will always be generated with the
correct bounds, just like that the ball will come to the user's feet and few
assumptions, it can be easily fixed if i should handle that in my story, but i
think we better wait and discuss this in tomorrow's integration meeting.
Original comment by q3a...@gmail.com
on 25 Apr 2012 at 11:59
This issue was updated by revision r547.
Fixed an unhandled solvability problem in my method, although it will be
handled somewhere else, but i just added a case for it for now
Original comment by q3a...@gmail.com
on 26 Apr 2012 at 9:19
This issue was updated by revision r553.
Added the hole generating methods in my GenerateSolvable method.
Committed by Badr and Khaled Salah
Original comment by q3a...@gmail.com
on 26 Apr 2012 at 9:51
make the activation box for class Experiment start earlier that it coveres the
call of method IsSolvable()
replaces all the alt's with opt's, opt's are used in if then else statements,
alt's are used for if then else statements know the difference
let the IsSolvable self called method by class Environment3 match the
actviation box...
remove the return types in the get messages you should only show the variable
returned
capitalize method names
same mistakes are repeated please check the whole design
Original comment by khaled.osmaan
on 26 Apr 2012 at 9:14
and how come is it a selfcall?? don't get it? developers will use an instance
of MKinect to set the framerate, this method is not directly called inside
framerate, can't be a selfcall.. and method names is NOT A PROBLEM!! UML = show
the flow of the code not show the "exact" code.
Original comment by q3a...@gmail.com
on 27 Apr 2012 at 10:10
wrong issue?
Original comment by khaled.osmaan
on 27 Apr 2012 at 10:22
[deleted comment]
issue 19, lol u got my point anyway
Original comment by q3a...@gmail.com
on 27 Apr 2012 at 11:30
"This method verifies whether a method is solvable."
"whether a method is solvable"? "whether the experiment is solvable" u mean?
also should be "whether or not"
Original comment by ams.sa...@gmail.com
on 27 Apr 2012 at 1:39
This issue was updated by revision r670.
Fixed documentation.
Documentation-Ready
Original comment by q3a...@gmail.com
on 27 Apr 2012 at 1:48
Original comment by q3a...@gmail.com
on 27 Apr 2012 at 1:49
Original comment by ams.sa...@gmail.com
on 27 Apr 2012 at 1:51
This issue was updated by revision r677.
Removed negativeFriction, because friction can be +ve or -ve
Original comment by q3a...@gmail.com
on 27 Apr 2012 at 2:20
did you fix this issue's uml design yet?, I think you set it to ready in your
previous comment which was on wrong issue by mistake
Original comment by khaled.osmaan
on 27 Apr 2012 at 2:44
This issue was updated by revision r689.
Changed the access modifier for method IsSolvable
Original comment by q3a...@gmail.com
on 27 Apr 2012 at 3:46
This issue was updated by revision r704.
Added negativeFriction again
Original comment by q3a...@gmail.com
on 27 Apr 2012 at 5:00
Original issue reported on code.google.com by
q3a...@gmail.com
on 13 Apr 2012 at 4:00