Open GoogleCodeExporter opened 9 years ago
Original comment by 3abdelazim
on 24 Apr 2012 at 9:58
Original comment by 3abdelazim
on 25 Apr 2012 at 11:03
- Diagram name not written!
- Stereo types are not used!
- The story number is 0.09 not 0.10
- missing if conditions
- will re review when those points are done isa
Original comment by mohamed....@gmail.com
on 25 Apr 2012 at 3:01
Original comment by 3abdelazim
on 25 Apr 2012 at 8:05
what do you mean by "diagram name"?
Original comment by 3abdelazim
on 25 Apr 2012 at 8:26
https://docs.google.com/file/d/0Bxa0a3NzcvtpcnJDdjhKSWhybFk/edit
Original comment by 3abdelazim
on 25 Apr 2012 at 9:55
Diagram name and other issues have been discussed on Skype
Original comment by mohamed....@gmail.com
on 26 Apr 2012 at 7:12
Diagram name and some issues have been discussed on Skype
Original comment by mohamed....@gmail.com
on 26 Apr 2012 at 7:15
-Please note the following comments:
-Summary is the first thing, and doesn't include any labels inside it.
-Return is the last thing in the documentation and not inside the summary
-You should write documentation for the class.
-There is return Tag in the documentation of the constructor and it doesn't
return anything.
Original comment by mohamedra2fat
on 26 Apr 2012 at 10:07
This issue was updated by revision r606.
adding action listener to the button, to swap to next screen
Original comment by 3abdelazim
on 27 Apr 2012 at 3:21
- Actor Activation Box not drawn
- Return Arrows Must be dotted.
- method calls should have the signature of the methods
- Wrong if condition !!
Please modify asap so that i can continue reviewing
Original comment by mohamed....@gmail.com
on 27 Apr 2012 at 1:22
This issue was updated by revision r681.
Status: In Progress
added .png photo to be used in abdelazim's screen (AdjustPosition.cs)
Original comment by mohamed....@gmail.com
on 27 Apr 2012 at 2:30
No actor Activation Box is required(just a note)
Original comment by mohamed....@gmail.com
on 27 Apr 2012 at 3:19
This issue was updated by revision r698.
Status: In Progress
Updating some GUI Issues
Original comment by mohamed....@gmail.com
on 27 Apr 2012 at 4:31
This issue was updated by revision r737.
solved a bug regarding null skeletons
Original comment by 3abdelazim
on 27 Apr 2012 at 6:54
This issue was updated by revision r758.
Edit Documentation
Original comment by 3abdelazim
on 27 Apr 2012 at 9:16
Original comment by mohamedra2fat
on 27 Apr 2012 at 9:50
Original comment by 3abdelazim
on 27 Apr 2012 at 9:54
Story Reopened in Sprint 2 with the following tasks
1) refine code regarding bars, create them as objects.
2) refine commands about user's position making it generalized to any class to
get it
3) recreate the gui in a neat way
Original comment by 3abdelazim
on 11 May 2012 at 9:44
Original comment by 3abdelazim
on 12 May 2012 at 10:51
This issue was updated by revision r917.
Created new Class DepthBar.cs
Separated DepthBar to be an object
Original comment by 3abdelazim
on 15 May 2012 at 12:30
This issue was updated by revision r918.
imported class "depthbar" in the solution
Original comment by 3abdelazim
on 15 May 2012 at 12:55
This issue was updated by revision r1066.
imported class "AngleBar" in the solution
refined the data flow to be based on OO programming
still need some more work to finish
Original comment by 3abdelazim
on 17 May 2012 at 8:43
This issue was updated by revision r1129.
Done with the Angle Bar
Original comment by 3abdelazim
on 18 May 2012 at 9:08
This issue was updated by revision r1130.
Done with the DepthBar
Original comment by 3abdelazim
on 18 May 2012 at 9:08
This issue was updated by revision r1131.
Done with the DepthBar
Original comment by 3abdelazim
on 18 May 2012 at 9:09
This issue was updated by revision r1132.
Updated AdjustPosition Screen
Original comment by 3abdelazim
on 18 May 2012 at 9:13
This issue was updated by revision r1180.
moved and updated DepthBar, AngleBar
Original comment by 3abdelazim
on 20 May 2012 at 11:00
This issue was updated by revision r1181.
Updated AdjustPosition Class to work with Objects DepthBar, AngleBar
Original comment by 3abdelazim
on 20 May 2012 at 11:01
Try the following screen with the following line
new AdjustPosition(new User2(), 150, 350, -20, 20, 2);
Original comment by 3abdelazim
on 20 May 2012 at 11:08
This issue was updated by revision r1182.
Updated SUO File to import new Classes
Original comment by 3abdelazim
on 20 May 2012 at 11:25
This issue was updated by revision r1236.
Deleted old DepthBar.cs Class
Original comment by 3abdelazim
on 20 May 2012 at 9:45
You have null reference exception.I cant test your code
Next Time,Test your code before making Scenario-Ready,there is no meaning in
making Scenario-Ready and your code is not working at all ! Test before you say
ready!
ScreenShot of what happened :
http://i.imgur.com/pcxJF.png
Original comment by hollaxy...@gmail.com
on 20 May 2012 at 10:56
This issue was updated by revision r1277.
Fixed a bug in User Class
Original comment by 3abdelazim
on 21 May 2012 at 6:03
This issue was updated by revision r1418.
Refined the code, fixed a bug
Original comment by 3abdelazim
on 23 May 2012 at 12:18
This issue was updated by revision r1428.
Refined and documented the code
Original comment by 3abdelazim
on 23 May 2012 at 1:39
This issue was updated by revision r1431.
Refined and documented the code
Original comment by 3abdelazim
on 23 May 2012 at 1:56
This issue was updated by revision r1433.
Removed unused Using Statements
Original comment by 3abdelazim
on 23 May 2012 at 2:00
This issue was updated by revision r1448.
Removed unused Using Statements, Refined and Documented Code.
Original comment by 3abdelazim
on 23 May 2012 at 3:14
This issue was updated by revision r1449.
Adjusted private and public declarations
Original comment by 3abdelazim
on 23 May 2012 at 3:32
This issue was updated by revision r1532.
Integrated with other stories
Original comment by 3abdelazim
on 23 May 2012 at 10:06
Original comment by 3abdelazim
on 24 May 2012 at 2:25
Just small comments:
-Add small documentation for the class itself, before class AdjustPosition
-change Author -> AUTHOR
Original comment by mohamedra2fat
on 24 May 2012 at 8:54
This issue was updated by revision r1685.
Added Background
Original comment by 3abdelazim
on 24 May 2012 at 3:02
I tested it with alot of ranges and it worked.However :
1)You need to delete title adjust position you wrote since it is already in the
background
2)You have problem of not detecting if i rotated by more than 45 degree right
or left.You can handle that by other ways without face recoginztion implemented
in kinect since v.1 that we use does not have it.Or We should work with V1.5
That got published yesterday :D :
http://msdn.microsoft.com/en-us/library/jj131036
However I think this should be done in Sprint 3 not sprint 2 because i know
that it have alot of work to do and to avoid problems.
Original comment by hollaxy...@gmail.com
on 24 May 2012 at 3:40
This issue was updated by revision r1718.
Adjusted UI
Original comment by 3abdelazim
on 24 May 2012 at 6:17
Original comment by 3abdelazim
on 24 May 2012 at 6:22
Depth bar not working correctly :
http://i.imgur.com/bemiX.jpg
Original comment by hollaxy...@gmail.com
on 24 May 2012 at 8:30
This issue was updated by revision r1799.
Adjusted Implementation
Original comment by 3abdelazim
on 24 May 2012 at 11:32
This issue was updated by revision r1818.
Adjusted Implementation
Original comment by 3abdelazim
on 25 May 2012 at 12:57
Original issue reported on code.google.com by
3abdelazim
on 12 Apr 2012 at 5:46