search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

3.08: As a user, I should know my status after the race end. #217

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
to-do list:
1- story sequence diagram & artifact.
2- check if any of both user finished the race and show the winner.
3- documentation of methods.

Original issue reported on code.google.com by michel.n...@gmail.com on 11 May 2012 at 8:09

GoogleCodeExporter commented 9 years ago

Original comment by michel.n...@gmail.com on 12 May 2012 at 8:45

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1013.

Added GetWinner method in Classes/Tools1.cs to return the winner of the race, 
it only needs to be drawn in the correct place from within the code

Original comment by michel.n...@gmail.com on 17 May 2012 at 1:56

GoogleCodeExporter commented 9 years ago 
the UML is now shared on Google Drive

Original comment by michel.n...@gmail.com on 17 May 2012 at 2:25

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1214.

edited method GetWinner to take an extra parameter which is the race length

Original comment by michel.n...@gmail.com on 20 May 2012 at 7:37

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1216.

Optimized method GetWinner

Original comment by michel.n...@gmail.com on 20 May 2012 at 7:42

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1233.

edited the logic in GetWinner to suit the new entries

Original comment by michel.n...@gmail.com on 20 May 2012 at 8:46

GoogleCodeExporter commented 9 years ago 
can't find the SD in your folder @ 
https://drive.google.com/#folders/0Bydej5CEyofhQ2VQSkZqcmd4NDA

Original comment by mohamed....@gmail.com on 23 May 2012 at 9:07

GoogleCodeExporter commented 9 years ago 
can't find the SD in your folder @ 
https://drive.google.com/#folders/0Bydej5CEyofhQ2VQSkZqcmd4NDA

Original comment by mohamed....@gmail.com on 23 May 2012 at 9:07

GoogleCodeExporter commented 9 years ago 
review GetWinner
it should be instance method in class Experiment 1
rename it to SelectWinner since it does not return the winners number

Original comment by bishoyba...@gmail.com on 24 May 2012 at 10:37

GoogleCodeExporter commented 9 years ago 
it doesn't return but it sets its instance variable so it should be Get 
(because in the integration part it shows who won), and it should not be in 
Experiment1 'cause not only Experiment1 may uses it!!

Original comment by michel.n...@gmail.com on 24 May 2012 at 4:05

GoogleCodeExporter commented 9 years ago 
try the UMLs now ya Zayat!!

Original comment by michel.n...@gmail.com on 24 May 2012 at 4:07

GoogleCodeExporter commented 9 years ago

Original comment by michel.n...@gmail.com on 24 May 2012 at 5:59

GoogleCodeExporter commented 9 years ago 
1 - what i see from the code is that ONLY Exp1 calls it
2 - yes it sets so it should be renamed to either SetWinnner or SelectWinner

Original comment by bishoyba...@gmail.com on 24 May 2012 at 6:07

GoogleCodeExporter commented 9 years ago 
but it must be able to be called anywhere, then the name was get because it was 
printing it, but I will change it anyways.

Original comment by michel.n...@gmail.com on 24 May 2012 at 6:16

GoogleCodeExporter commented 9 years ago

Original comment by asamg...@gmail.com on 24 May 2012 at 7:30

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1751.

Deprecated method GetWinner to use SetWinner instead (for implementation issues)

Original comment by michel.n...@gmail.com on 24 May 2012 at 8:33

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1798.

Changed GetWinnerTest to SetWinnerTest to solve the error.

Original comment by michel.n...@gmail.com on 24 May 2012 at 11:29

GoogleCodeExporter commented 9 years ago 
can't find the SD @ 
https://drive.google.com/#folders/0Bydej5CEyofhQ2VQSkZqcmd4NDA
:@:@:@

upload them to the shared folder not to your documents!

Original comment by mohamed....@gmail.com on 25 May 2012 at 9:45

GoogleCodeExporter commented 9 years ago 
https://docs.google.com/document/d/1BCyPnGAQSpdnE96Wwjgd3z0ghKakyUpG-8AZmRj0N_A/
edit

here is the link

Original comment by michel.n...@gmail.com on 25 May 2012 at 10:54

GoogleCodeExporter commented 9 years ago 
again please move the method to class Exp1 as an instance method without user1 
and user2 parameters

Original comment by bishoyba...@gmail.com on 25 May 2012 at 2:26

GoogleCodeExporter commented 9 years ago 
Again this method should be moved and should be available for any method to use.

Original comment by michel.n...@gmail.com on 25 May 2012 at 3:02

GoogleCodeExporter commented 9 years ago 
UML at:

https://docs.google.com/document/d/16-yOdT0tPQUyP6EXkPwj-4BxMDrskl7RpBrb4KWbLOw/
edit

Original comment by michel.n...@gmail.com on 25 May 2012 at 5:35

GoogleCodeExporter commented 9 years ago 
please accept my request to view your document !
you need to make share it with terasoft and make sure it's on the shared folder 
!

Original comment by mohamed....@gmail.com on 25 May 2012 at 6:18

GoogleCodeExporter commented 9 years ago 
Here is the UML

Original comment by michel.n...@gmail.com on 25 May 2012 at 6:27

Attachments:

GoogleCodeExporter commented 9 years ago 
*The UML Name doesn't match the convention : Diagram Type Diagram Name
in this case Diagram Type should be "sd" which means sequence diagram
**Missing the diagram name (you added only the diagram type)!!
*The Actor lifeline should have no activation box
**please use Stereo types ON ALL THE CLASSES NOT JUST THE USER 
<<Actor>>,<<UI>>,<<System>>,.....
* The returning arrows of the synchronous calls are missing !!
something like:
<--------------------------------------------

*The arrow head should be at the beginning of the activation box
and the returning arrow should start at the end of the activation box!
something like:
_________________________>|-|
                          | |
                          | |
                          | |
                          | |
                          | |
                          | |
<-------------------------|_|

Original comment by mohamed....@gmail.com on 25 May 2012 at 8:37

GoogleCodeExporter commented 9 years ago

Original comment by michel.n...@gmail.com on 25 May 2012 at 9:46