search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

215:As a user i should be able to see grass, in the environment. #220

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This story will add a grass effect to the environment.

Original issue reported on code.google.com by ams.sa...@gmail.com on 11 May 2012 at 8:20

GoogleCodeExporter commented 9 years ago 
Added Omar to the CC field.

Original comment by ams.sa...@gmail.com on 12 May 2012 at 3:26

GoogleCodeExporter commented 9 years ago

Original comment by ams.sa...@gmail.com on 16 May 2012 at 5:26

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1021.

Status: In Progress

Added a grass texture to the project.

Original comment by ams.sa...@gmail.com on 17 May 2012 at 3:21

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1022.

Status: In Progress

Added the grass texture to the solution.

Original comment by ams.sa...@gmail.com on 17 May 2012 at 3:23

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1030.

Status: In Progress

Added an HLSL file containing a technique for adding a texture to the terrain.

Original comment by ams.sa...@gmail.com on 17 May 2012 at 4:33

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1035.

Status: In Progress

Added code for adding a grass texture to the terrain, but commented, due to 
other people having errors preventing me from testing.

Original comment by ams.sa...@gmail.com on 17 May 2012 at 4:43

GoogleCodeExporter commented 9 years ago

Original comment by ams.sa...@gmail.com on 18 May 2012 at 7:31

GoogleCodeExporter commented 9 years ago 
Commit for r1350 was meant to be here not in issue 39. Added explanatory 
comments to the MYHLSL.fx file, as a type of documentation. Asked Ghoroury 
about the design/sequence diagram, he said he would ask, still awaiting his 
reply.

Original comment by ams.sa...@gmail.com on 22 May 2012 at 11:01

GoogleCodeExporter commented 9 years ago 
public int terrainWidth { get; private set; }
public int terrainHeight { get; private set; }
Properties should start with an uppercase. They are not the only lowercase 
properties, so fix them all.

some variables having default access modifier, is that for a reason? if not use 
private

Constructor shouldn't contain UI componenets, ContentManager content, 
GraphicsDevice device and all such variables shall be removed from the 
constructor.(if someone is using these variables other than you, just remove 
them and notify those people, this is critical)

The class having 2 constructors, both of them needed?

variables xComp, yComp names are not descriptive enough

Remove all engine from LoadContent, it contains a lot of initializations for 
non UI stuff.

GraphicsDevice g, give a better name(not the only variable, please fix all 
namings, i also saw a variable named pp..)

skyDome.Meshes[0].MeshParts[0].Effect = effect.Clone();
why are you cloding effect, why not skyDome.Meshes[0].MeshParts[0].Effect = 
effect?

float time = (float)gameTime.TotalGameTime.TotalMilliseconds / 100.0f; use var

Original comment by q3a...@gmail.com on 23 May 2012 at 11:59

GoogleCodeExporter commented 9 years ago 
use parantheses around arithmatic operations in MYHLSL file

leave space before and after the colons(ex. float2 TextureCoords : TEXCOORD1;)

Rename file to something more descriptive and don't let the name be all 
uppercase

Original comment by q3a...@gmail.com on 23 May 2012 at 2:37

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 24 May 2012 at 11:42

GoogleCodeExporter commented 9 years ago 
https://cacoo.com/diagrams/gTtS6xwEwhAjmxff
As for adding HLSL to the diagram, I was unable to find any way to do this, and 
as far as I understand it shouldn't be done. Sent a mail to ghoroury to ask 
him, awaiting his reply, though I can't see why he insists I do this.

Original comment by ams.sa...@gmail.com on 24 May 2012 at 2:14

GoogleCodeExporter commented 9 years ago 
1. Show stereotypes.
2. Methods overlapping on activation box. 
3. Lifeline title should be instanceName : className <<Stereotype>> 
4. activation box for camera.
5. LoadContent akeed isnt called in the same instance the user wishes to see 
the whatever. Mind Timing in messages.

Original comment by vendett...@gmail.com on 24 May 2012 at 5:40

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 24 May 2012 at 5:52

GoogleCodeExporter commented 9 years ago 
https://cacoo.com/diagrams/ydKhJTn4Z7LJ9pqQ

Original comment by ams.sa...@gmail.com on 24 May 2012 at 7:15

GoogleCodeExporter commented 9 years ago 
LoadEnvironmentContent in environment overlaps on lifeline.
Also its called in the same instance. Mind time again :)

Original comment by vendett...@gmail.com on 24 May 2012 at 7:28

GoogleCodeExporter commented 9 years ago 
some lines are longer tham 120

Original comment by q3a...@gmail.com on 24 May 2012 at 9:51

GoogleCodeExporter commented 9 years ago 
https://cacoo.com/diagrams/ydKhJTn4Z7LJ9pqQ

Original comment by ams.sa...@gmail.com on 24 May 2012 at 11:16

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1806.

Status: In Progress

Changed the HLSL file to follow the conventions invented by the reviewer, 
although HLSL has no conventions.

Original comment by ams.sa...@gmail.com on 24 May 2012 at 11:47

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1807.

Status: In Progress

Fixed things asked by reviewer.

Original comment by ams.sa...@gmail.com on 24 May 2012 at 11:54

GoogleCodeExporter commented 9 years ago 
Fixed implementation.

Original comment by ams.sa...@gmail.com on 24 May 2012 at 11:55

GoogleCodeExporter commented 9 years ago

Original comment by ams.sa...@gmail.com on 25 May 2012 at 12:02

GoogleCodeExporter commented 9 years ago 
Please upload on gdocs

Original comment by vendett...@gmail.com on 25 May 2012 at 12:03

GoogleCodeExporter commented 9 years ago

Original comment by q3a...@gmail.com on 25 May 2012 at 6:17