search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

112: As a user I should see an avatar #221

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Implementation I: creating the model
Implementation II: importing the model to the enviroment
Implementation III: defining the joints of the model representing the skeleton

Original issue reported on code.google.com by ahmedheg...@gmail.com on 11 May 2012 at 8:40

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 12 May 2012 at 8:30

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1143.

adding method MoveBone to class SkinnedCustomModel

Original comment by ahmedheg...@gmail.com on 19 May 2012 at 8:09

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1144.

updating the name space of SkinnedCustomModel

Original comment by ahmedheg...@gmail.com on 19 May 2012 at 8:13

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1145.

Updating documentation of class SkinnedCustomModel

Original comment by ahmedheg...@gmail.com on 19 May 2012 at 10:17

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1146.

Adding class KineckAnimation

Original comment by ahmedheg...@gmail.com on 19 May 2012 at 10:19

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1147.

changing the protection level to public in class KineckAnimation.

Original comment by ahmedheg...@gmail.com on 19 May 2012 at 11:09

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 19 May 2012 at 12:12

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1200.

clearing the code after implementation review.

Original comment by ahmedheg...@gmail.com on 20 May 2012 at 3:07

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1201.

clearing the code after implementation review.

Original comment by ahmedheg...@gmail.com on 20 May 2012 at 3:08

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 20 May 2012 at 3:09

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1205.

integrating the animation withe the player in the environment

Original comment by ahmedheg...@gmail.com on 20 May 2012 at 3:23

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1206.

fixing the left leg in method MovelLeftLeg()

Original comment by ahmedheg...@gmail.com on 20 May 2012 at 3:29

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1267.

moving class SkinnedCustomModel to UI library. Fixing the caused errors in: 
Environment3 and KineckAnimation.
Adding the required references in UI project.

Original comment by ahmedheg...@gmail.com on 21 May 2012 at 3:54

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1268.

updating the solution by adding the missing projects.

Original comment by ahmedheg...@gmail.com on 21 May 2012 at 3:56

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1419.

extending class CustomModel. changing PlayerModel.Draw() in class Environment3.

Original comment by ahmedheg...@gmail.com on 23 May 2012 at 12:19

GoogleCodeExporter commented 9 years ago 
Class KinectAnimation

"the model to animate"
Capitalize and add a '.' and "The model that will be animated" is better I 
think?

"the user which is tracked"
Capitalize and add a '.' and "The user that will be tracked" is better I thinked

"Updating the movement"
"Updates" and add a '.'

"Animating the the right leg"
Animates and add a '.'

"Animating the left leg"
same as the previous line

Class SkinnedCustomModel

"used for a 3D model with skeleton and skin."
Seems wrong and I don't understand it. And shouldn't a constructor say 
Initializes and instance of <object name> blah blah something like that?

"the model"
Capitalize and add a '.' and what model?

"the position of the model" and
"the rotation of the model"
Capitalize and add a '.' and what is the rotation of the model? It is a 
vector3, shouldn't you say how it maps to rotation in angles or degrees or 
something?

"scaling the model"
"The scale of the model."? why is this one written different than the ones 
above it? they were correct.

"updating the model if any achanges occurred to its skin or bones"
Capitalize and add a '.' & "Updates" & "achanges" spelling mistkake

"updating the world view of every bone according to the changes to its parent 
bone"
Capitalize and add a '.' & "Updates" & comma before according

"updating the changes of the skin according to the changes in the bones."
Same as above

"drawing the model"
Draws the model.

/// <param name="gameTimem">GameTime object</param>
/// <param name="view">The Camera's View</param>
/// <param name="projection">The Camera's Projection</param>
/// <remarks>
/// <para>Author: AhmeD HegazY</para>
/// </remarks>
public override void Draw(Camera c)
Wrong parameters?

"moving a specific bone "
Moves a specific bone.

"the name of the bone, same as in the model"
Capitalize and add a '.' and "which is the same as the one in the model" or 
something like that would be better

"the number of extra bone information"
Capitalize and add a '.' and what does it mean? Can you make it more 
descriptive?

<param name="bend">the binding of the bone in 3D</param>
Capitalize and add a '.' and what does the binding mean? Can you make it more 
descriptive?

Once again: AUTHOR: instead of Author: Also please write your name in the same 
way everywhere. Here you wrote AhmeD HegazY while in other places you only 
wrote HegazY

Original comment by ams.sa...@gmail.com on 23 May 2012 at 4:19

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1485.

Editing the documentation of class KineckAnimation.

Original comment by ahmedheg...@gmail.com on 23 May 2012 at 5:33

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1486.

Editing the documentation of class SkinnedCustomModel.

Original comment by ahmedheg...@gmail.com on 23 May 2012 at 5:40

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 23 May 2012 at 5:51

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 23 May 2012 at 5:51

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1694.

deleting unnecessary initializations from the constructor. SkinnedCustomModel

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 3:48

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1730.

adding LoadContent method to class SkinnedCustomModel. and calling it in 
Environment3

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 7:37

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 8:03

GoogleCodeExporter commented 9 years ago 
The model looks like its floating over the environment, and its legs keeps 
moving, can you please fix that? make it detect a motion only if the depth of 
foot is changed enough distance its too sensitive

Original comment by khaled.osmaan on 24 May 2012 at 8:42

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1756.

Editing the documentation in classes KineckAnimation and SkinnedCustomModel.

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 8:52

GoogleCodeExporter commented 9 years ago 
the motion of the leg is not my story !!! it's just an extra feature that I
added !!!
and it's floating maybe because the legs gets affected by the kinect, and
as I said it's not my story !!!
and if the problem because the position, well it's not my problem also,
because I use a variable to set the position of the avatar by Badr I guess.

Please read the description of the story to understand clearly what is my
job !!!

thank you.

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 9:04

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 9:04

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1764.

Editing the documentation in classes SkinnedCustomModel.

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 9:47

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1766.

Editing the documentation in classes KineckAnimation.

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 9:50

GoogleCodeExporter commented 9 years ago

Original comment by ams.sa...@gmail.com on 25 May 2012 at 11:29

GoogleCodeExporter commented 9 years ago 
No one else has the avatar story, you added the skinned model and you animate 
it just add an if statement like I told you before animating to track a certain 
depth or more, its way too sensitive its kinda annoying

Original comment by khaled.osmaan on 25 May 2012 at 1:45

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 25 May 2012 at 1:49

GoogleCodeExporter commented 9 years ago 
I told you it is not my story to Animate the Avatar !!! please read
the description of the story !!!

Original comment by ahmedheg...@gmail.com on 25 May 2012 at 1:49

GoogleCodeExporter commented 9 years ago 
who's story is it then?

Original comment by khaled.osmaan on 25 May 2012 at 1:54

GoogleCodeExporter commented 9 years ago 
the avatar is obviously animated and whoever animates it whether its his story 
or an extra should be reviewed for it. you could've fixed it already and I 
believe you're the only one responsible for the avatar as whole.

Original comment by khaled.osmaan on 25 May 2012 at 1:58

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 25 May 2012 at 2:02

GoogleCodeExporter commented 9 years ago 
Ok !!! the story of animating the avatar does not exist in this sprint, it
will be in sprint 3, isa !!! Yes, I created this animation just to make to
game more friendly, it is an extra thing that I did !!!

I've talked to ghorory about that, and he told me that if it is not my
story, then i shouldn't care about it now !!!

Original comment by ahmedheg...@gmail.com on 25 May 2012 at 2:02

GoogleCodeExporter commented 9 years ago 
Verified considering that the animation is not part of this story and will be 
reimplemented in sprint3

Original comment by khaled.osmaan on 25 May 2012 at 2:09

GoogleCodeExporter commented 9 years ago

Original comment by mk.cena92 on 25 May 2012 at 8:11