search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

105:As a user I can shoot the ball with a certain speed & angle #223

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Rework of issues 25 & 26
Implementation I: Get the velocity of the user's leg
Implementation II: If the ball has collided with the user's leg and the 
countdown bar has reached 0, I should change the velocity of the ball 
considering momentum conservation laws.

Original issue reported on code.google.com by vendett...@gmail.com on 11 May 2012 at 9:44

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 11 May 2012 at 10:35

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r953.

Changed method CalculateCollision in Environment3

Original comment by vendett...@gmail.com on 16 May 2012 at 7:01

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1027.

Added Constants to Constants3 class

Original comment by vendett...@gmail.com on 17 May 2012 at 4:26

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1029.

Made Changes to methods in Ball Control Region.

Original comment by vendett...@gmail.com on 17 May 2012 at 4:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1031.

Added calls to methods to shoot the ball.

Original comment by vendett...@gmail.com on 17 May 2012 at 4:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1033.

Updated documentation of methods.

Original comment by vendett...@gmail.com on 17 May 2012 at 4:39

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1040.

Fixed errors

Original comment by vendett...@gmail.com on 17 May 2012 at 5:20

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1075.

Fixed all errors

Original comment by vendett...@gmail.com on 17 May 2012 at 9:39

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1076.

Added method GetVelocityAfterCollision

Original comment by vendett...@gmail.com on 17 May 2012 at 9:43

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1080.

Fixed errors

Original comment by vendett...@gmail.com on 17 May 2012 at 9:59

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1081.

Deprecating BallAnimation constructor.

Original comment by vendett...@gmail.com on 17 May 2012 at 10:03

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1083.

Fixed errors

Original comment by vendett...@gmail.com on 17 May 2012 at 10:11

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1087.

Fixed errors

Original comment by vendett...@gmail.com on 17 May 2012 at 10:18

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1089.

Fixed errors

Original comment by vendett...@gmail.com on 17 May 2012 at 10:25

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1092.

Changed GetVelocityAfterCollision to Environment3

Original comment by vendett...@gmail.com on 17 May 2012 at 11:02

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 18 May 2012 at 2:47

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 20 May 2012 at 5:06

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 21 May 2012 at 11:23

GoogleCodeExporter commented 9 years ago 
Shoot(): return user.velocity directly. It should be in class User3

hasBallEnteredShootRegion(): a line shouldn't exceed 120 characters and group 
variables between operators. It should be in class Ball.

Original comment by ahmedheg...@gmail.com on 23 May 2012 at 8:46

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1414.

Made changes due to reviewing

Original comment by vendett...@gmail.com on 23 May 2012 at 11:45

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1415.

Made changes due to reviewing

Original comment by vendett...@gmail.com on 23 May 2012 at 11:46

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 23 May 2012 at 11:47

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1420.

Removed exception handling

Original comment by vendett...@gmail.com on 23 May 2012 at 12:30

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 23 May 2012 at 4:38

GoogleCodeExporter commented 9 years ago 
Class Ball
"Checks whether the ball entered the region user can shoot in."
Should be "the shooting region" like you wrote in the return, or something like 
that.

Class Environment3
"Calculates Velocity after collision using conservation of momentum laws."
Velocity shouldn't be capitalized... it should be "Calculates the velocity"

"Vector3 velocity after collision"
'.'

Original comment by ams.sa...@gmail.com on 23 May 2012 at 7:26

GoogleCodeExporter commented 9 years ago 
sure thing huni

Original comment by vendett...@gmail.com on 23 May 2012 at 7:30

GoogleCodeExporter commented 9 years ago 
GetVelocityAfterCollision(Vector3 initialVelocity) lacks an author tag
and forgot to reopen

Original comment by ams.sa...@gmail.com on 23 May 2012 at 7:46

GoogleCodeExporter commented 9 years ago 
an Exception occurs when setting ball mass in method GetVelocityAfterCollision 
when trying to shoot the ball

Original comment by khaled.osmaan on 24 May 2012 at 10:12

GoogleCodeExporter commented 9 years ago 
>>class Ball:
*hasBallEnteredShootRegion(): method name starts with an uppercase. No need for 
the the variables ?!

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 10:38

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 24 May 2012 at 3:13

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1691.

Deprecating method GetVelocityAfterCollision.

Original comment by vendett...@gmail.com on 24 May 2012 at 3:20

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1712.

Set arrive velocity

Original comment by vendett...@gmail.com on 24 May 2012 at 5:33

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
you still didn't move GetVelocityAfterCollision() to the physics library !!

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 6:35

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1726.

Implementation changes.

Original comment by vendett...@gmail.com on 24 May 2012 at 7:22

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1745.

Implementation changes.

Original comment by vendett...@gmail.com on 24 May 2012 at 8:24

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 24 May 2012 at 10:03

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 24 May 2012 at 10:04

GoogleCodeExporter commented 9 years ago 
>>class Functions:
GetVelocityAfterCollision():
*a line shouldn't exceed 120 characters.
*the number zero is between parenthesis, why ?!! no need !!!

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 10:50

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1790.

Implementation changes.

Original comment by vendett...@gmail.com on 24 May 2012 at 10:53

GoogleCodeExporter commented 9 years ago 
ma 5las ba2a ya 7egz :D

Original comment by vendett...@gmail.com on 24 May 2012 at 10:54

GoogleCodeExporter commented 9 years ago 
ana nefsy wallahy !! shed enta bs O 5ally sho3'lak ndeef !!

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 11:01

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 11:04

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 25 May 2012 at 1:50

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 25 May 2012 at 5:20

GoogleCodeExporter commented 9 years ago

Original comment by ams.sa...@gmail.com on 25 May 2012 at 5:21

GoogleCodeExporter commented 9 years ago 
- you should indicate the Object type of that the method returns 
objectName:Class

Original comment by mk.cena92 on 25 May 2012 at 8:44

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 25 May 2012 at 8:45

GoogleCodeExporter commented 9 years ago

Original comment by mk.cena92 on 25 May 2012 at 8:54

GoogleCodeExporter commented 9 years ago

Original comment by mk.cena92 on 25 May 2012 at 8:54