search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

13 As a user, I should hear commands after the countdown #224

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Here my method SayText(string text) should receive a string and let the user 
hear it.

Tasks:
1- Story sequence diagram & artifact.
2- Documentation of method.
3- Implement the method sayText(string text.

Original issue reported on code.google.com by mohamed....@gmail.com on 11 May 2012 at 9:46

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r809.

Status: Ready

Implementation ready,
Design Ready,
Documentation Ready,
Scenario Ready

Original comment by mohamed....@gmail.com on 13 May 2012 at 9:40

GoogleCodeExporter commented 9 years ago 
update issue 224

Status: Ready

Design Ready at : 
https://docs.google.com/file/d/0B6N4YYWbSqySRDMxSGI1a0RRZ3M/edit
Every Thing is Ready for Reviewing.

Original comment by mohamed....@gmail.com on 13 May 2012 at 9:44

GoogleCodeExporter commented 9 years ago 
update issue 224

Status: In-Progress

Sorry for wrong status!

Original comment by mohamed....@gmail.com on 13 May 2012 at 9:45

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r810.

Status: In-Progress

Made the SayText method static.

Original comment by mohamed....@gmail.com on 13 May 2012 at 10:01

GoogleCodeExporter commented 9 years ago 
you shouldn't initialize variables while declaring them, make another static 
method that initializes the SpeechSynthesizer and sets it's volume. or create 
the SpeechSynthesizer within inside the SayText method without declaring it as 
a static variable

Original comment by 3abdelazim on 13 May 2012 at 10:06

GoogleCodeExporter commented 9 years ago 
otherwise, you can make it object oriented.

Original comment by 3abdelazim on 13 May 2012 at 10:08

GoogleCodeExporter commented 9 years ago 
feh many ways to do it
I think the best is to keep it as it's but removing the initialization of 
SpeechSynthesizer. inside the method you check whether it is null or not. if 
null, create and set volume.

Original comment by 3abdelazim on 13 May 2012 at 10:12

GoogleCodeExporter commented 9 years ago 
another note, make the variable private

Original comment by 3abdelazim on 13 May 2012 at 10:15

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r811.

Status: In-Progress

*Changed the name of Class1.cs to UILib.cs
*Made the Class a static one.
*Solved the implementation conventions issues after reading my implementation 
reviewer comments.

Original comment by mohamed....@gmail.com on 13 May 2012 at 10:15

GoogleCodeExporter commented 9 years ago 
update issue 224

Status: In-Progress

Solved the convention problems that you noted out.
Now no need to make it private.

Original comment by mohamed....@gmail.com on 13 May 2012 at 10:17

GoogleCodeExporter commented 9 years ago 
I already told you that this is acceptable,  but on another thought, it's 
better to declare the variable outside the method, and initiate it inside in 
case it's still null. you don't have to create a new object for each sentence

Original comment by 3abdelazim on 13 May 2012 at 10:34

GoogleCodeExporter commented 9 years ago 
note:
1) when declaring the variable, make it private
2) change the name of the variable to speechSynthesizer

Original comment by 3abdelazim on 13 May 2012 at 10:41

GoogleCodeExporter commented 9 years ago 
Nice UML, when you set the volume to 100.. what do you get in return?
and what sort of prompt you get from the Asynch?

Original comment by asafty2...@gmail.com on 15 May 2012 at 1:00

GoogleCodeExporter commented 9 years ago 
@3abdelazim: it's one of two things:
either i have my method as a separate static unit  with the synth variable 
declared and initialized inside it (initialize at every call)
or have a private instance variable declared and initialized.(fully loaded once 
the game starts and kept in memory)

@safty: Thank you, as for the volume you are right, but it is a field i mean i 
assigned it by saying volume = 100; in fact i didn't know how should it be done 
( i will re check )

Original comment by mohamed....@gmail.com on 15 May 2012 at 5:51

GoogleCodeExporter commented 9 years ago 
we discussed it face to face
but I'm gonna write what we agreed on here again

You should declare the variable outside, in constants class. and initiate it 
inside the method if it's still null
don't forget to use a full name to the variable

Original comment by 3abdelazim on 17 May 2012 at 7:32

GoogleCodeExporter commented 9 years ago 
Design-Verified, keep it up

Original comment by asafty2...@gmail.com on 18 May 2012 at 7:33

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1128.

Status: In-Progress

*Solved the implementation conventions issues after reading my implementation 
reviewer comments.
Implementation Ready 
Design Ready : https://docs.google.com/file/d/0B6N4YYWbSqySclVXcU5hdW80MTQ/edit

Original comment by mohamed....@gmail.com on 18 May 2012 at 8:22

GoogleCodeExporter commented 9 years ago 
Changing Labels 
Sorry Safty but had to change the implementation

Original comment by mohamed....@gmail.com on 18 May 2012 at 8:23

GoogleCodeExporter commented 9 years ago 
Added Safty as a reviewer

Original comment by mohamed....@gmail.com on 18 May 2012 at 8:24

GoogleCodeExporter commented 9 years ago 
setting the volume should be during initializing the speechSynthesizer

Original comment by 3abdelazim on 21 May 2012 at 12:30

GoogleCodeExporter commented 9 years ago 
Implementation Ready

Original comment by mohamed....@gmail.com on 22 May 2012 at 9:52

GoogleCodeExporter commented 9 years ago

Original comment by 3abdelazim on 25 May 2012 at 1:02

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 25 May 2012 at 6:28

GoogleCodeExporter commented 9 years ago 
Design is Verified

Original comment by asafty2...@gmail.com on 25 May 2012 at 6:28

GoogleCodeExporter commented 9 years ago

Original comment by mohamedra2fat on 25 May 2012 at 9:09

GoogleCodeExporter commented 9 years ago 
Done El7

Original comment by mohamed....@gmail.com on 25 May 2012 at 9:13