khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

Changes related to class Ball #227

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
1 - class Ball will extend CustomModel class
2 - maxMass and minMass instance variables will be removed
3 - float GenerateBallMass() will be changed to 
void GenerateBallMass(float minMass, float maxMass)
4 - initialBallPosition, initialVelocity, velocity attributes will be moved to 
class Experiment3

Original issue reported on code.google.com by bishoyba...@gmail.com on 11 May 2012 at 11:24

GoogleCodeExporter commented 9 years ago
5 - Ball ball will be moved from Environment3 class to Experiment3

Original comment by bishoyba...@gmail.com on 12 May 2012 at 12:04

GoogleCodeExporter commented 9 years ago
i think en GenerateBallMass is related to Khaled.

I don't agree on #4

Original comment by q3a...@gmail.com on 13 May 2012 at 4:08

GoogleCodeExporter commented 9 years ago
#2,#3 are mine i kinda agree.

Original comment by mk.cena92 on 13 May 2012 at 4:11

GoogleCodeExporter commented 9 years ago
Nah, I generate the user's leg mass :D... as far as I can remember it's cena's 
story

Original comment by khaled.osmaan on 13 May 2012 at 4:12

GoogleCodeExporter commented 9 years ago
None of the 5 are related to me in any way? Why am I CCed?

Original comment by ams.sa...@gmail.com on 13 May 2012 at 4:17

GoogleCodeExporter commented 9 years ago
number 5 is related to you sanad since BallFinalPosition and HasScored use the 
ball instance in Environment3 so they have to be moved to Experiment3 class

Badr state why you disagree

Original comment by bishoyba...@gmail.com on 13 May 2012 at 9:37

GoogleCodeExporter commented 9 years ago
look at the variable's name, BallFinalPosition... it's just related to the 
ball..

Original comment by q3a...@gmail.com on 13 May 2012 at 10:08

GoogleCodeExporter commented 9 years ago
I agree with badr, as they are attributes of the ball, making this proper
object orientation.

Original comment by ams.sa...@gmail.com on 14 May 2012 at 5:24

GoogleCodeExporter commented 9 years ago
why is ball moved to experiment3 ? isnt experiment3 class representing the 
screen  ?

Original comment by vendett...@gmail.com on 16 May 2012 at 6:35