search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

0.16:As C1,C2,C3,C4, i should be provided with a screenManager #238

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As C1,C2,C3,C4, i should be provided with a screenManager

Original issue reported on code.google.com by q3a...@gmail.com on 12 May 2012 at 9:30

GoogleCodeExporter commented 9 years ago

Original comment by q3a...@gmail.com on 12 May 2012 at 9:40

GoogleCodeExporter commented 9 years ago

Original comment by q3a...@gmail.com on 17 May 2012 at 2:18

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1014.

Deprecated method Update(GameTime gameTime,bool covered)

will be replaced by Update(GameTime gameTime)

Original comment by q3a...@gmail.com on 17 May 2012 at 2:19

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1016.

Removed useless ScreenStates
Removed some unused variables
Removed some unused functions from the ScreenManager

Original comment by q3a...@gmail.com on 17 May 2012 at 2:56

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1017.

Modified the class to be up to date with the latest changes done in GameSceen 
class

Original comment by q3a...@gmail.com on 17 May 2012 at 2:57

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1023.

Added new and better Mechanism for freezing screens

Original comment by q3a...@gmail.com on 17 May 2012 at 3:29

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1024.

Deprecated method ExitScreen()
Remove unused variables

Original comment by q3a...@gmail.com on 17 May 2012 at 3:48

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1028.

Added Documentation for classes GameScreen.cs and ScreenManager.cs

Original comment by q3a...@gmail.com on 17 May 2012 at 4:26

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1061.

Changed the implementation for Freeze, Unfreeze

Original comment by q3a...@gmail.com on 17 May 2012 at 7:57

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1322.

Loaded all the screens before the game starts

Original comment by q3a...@gmail.com on 22 May 2012 at 10:23

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1336.

Reverting back to old screenManager

Original comment by q3a...@gmail.com on 22 May 2012 at 10:23

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1340.

changes files according to the latest screenManager reverting back

Original comment by q3a...@gmail.com on 22 May 2012 at 10:24

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1341.

changes files according to the latest screenManager reverting back

Original comment by q3a...@gmail.com on 22 May 2012 at 10:24

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1342.

changes files according to the latest screenManager reverting back

Original comment by q3a...@gmail.com on 22 May 2012 at 10:25

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1351.

Switched the Initialize and LoadContent statements as Initialize should be 
before LoadContent

Original comment by q3a...@gmail.com on 22 May 2012 at 10:35

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1384.

Changed some code due to the latest changes

Original comment by q3a...@gmail.com on 23 May 2012 at 10:01

GoogleCodeExporter commented 9 years ago

Original comment by q3a...@gmail.com on 23 May 2012 at 10:02

GoogleCodeExporter commented 9 years ago 
Class GameScreen

This class represents the screen of the game
Add a '.'

some methods don't have documentation (such as LoadContent()), and some lack 
author tags (such as Remove()) also is the method Update yours? If so then 
"represents the time of the game." needs to be capitalized and why does it say 
"/// khaled salah"?

Original comment by ams.sa...@gmail.com on 23 May 2012 at 11:37

GoogleCodeExporter commented 9 years ago 
Class ScreenManager

"Return the sprite batch object." 
Should be "Returns"

"Constructor, initializes the manager"
Add a '.' and it is not a proper sentence. Either remove the word constructor, 
or make it something like "The constructor which initializes..." 

"Initialize the spriteBatch and screen dedicated content."
what is "screen dedicated content"? Do you mean "the screen's dedicated 
content" for example? I don't quite understand what you mean, but it looks 
wrong.

"Unload screen dedicated content"
Same as last comment. Also add a '.'

"Updates all the screens that should be drawn in a first in first updated 
manner."
What does "a first in first updated manner" mean? Do you mean something like 
FIFO? If so add a comma "first in, first updated" or something, as it is 
unclear.

"Draws all the screens that should be drawn in a first in first drawn manner."
Same as last comment.

represents the time of the game.
Capitalize.

"Represents the screen that should be removed from the list of managed screens 
by the screenManager"
Run-on sentence, add commas. Also lacks a '.'

All methods lack Author tags

Original comment by ams.sa...@gmail.com on 23 May 2012 at 11:49

GoogleCodeExporter commented 9 years ago 
https://cacoo.com/diagrams/OmBjFrZDxCN8G8XU

Original comment by q3a...@gmail.com on 23 May 2012 at 6:58

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1639.

Fixed documentation

Original comment by q3a...@gmail.com on 24 May 2012 at 10:32

GoogleCodeExporter commented 9 years ago

Original comment by q3a...@gmail.com on 24 May 2012 at 11:15

GoogleCodeExporter commented 9 years ago 
AddToScreens ??? Whats that ? 
I guess.. first the user creates a screen and then calls ScreenManager.add

Original comment by vendett...@gmail.com on 24 May 2012 at 6:01

GoogleCodeExporter commented 9 years ago 
Add to screens is an used to abstract the logic of adding this screen to the 
list of screens that are managed by the screen manager.. and i don't care if 
the user creates a screen or not, this is totally irrelevant and doesn't add 
anything to the diagram, i only care that the screen is added, not 
when/where/how it was created

Original comment by q3a...@gmail.com on 25 May 2012 at 11:09

GoogleCodeExporter commented 9 years ago 
I was just asking.
And you didnt fix the second point.

Original comment by vendett...@gmail.com on 25 May 2012 at 11:12

GoogleCodeExporter commented 9 years ago 
screenManager is working fine

Original comment by khaled.osmaan on 25 May 2012 at 11:18

GoogleCodeExporter commented 9 years ago 
anhy 2nd point?
i only see 1 comment
AddToScreens ??? Whats that ? 
I guess.. first the user creates a screen and then calls ScreenManager.add

and i replied.

Original comment by q3a...@gmail.com on 25 May 2012 at 11:20

GoogleCodeExporter commented 9 years ago 
You should show the developer creating the f screen ... and then adding it. 
"I guess.. first the user creates a screen and then calls ScreenManager.add"

Original comment by vendett...@gmail.com on 25 May 2012 at 11:24

GoogleCodeExporter commented 9 years ago 
fading screen is not created, it is extended. Please have a look at the classes

Original comment by q3a...@gmail.com on 25 May 2012 at 11:30

GoogleCodeExporter commented 9 years ago 
Yes, the user creates a screen, what does that have to do with the sequence 
diagram showing a screen being added?

Original comment by q3a...@gmail.com on 25 May 2012 at 11:32

GoogleCodeExporter commented 9 years ago 
Activation box for GameScreen. 
Box for methods Initialize and LoadContent

Original comment by vendett...@gmail.com on 25 May 2012 at 11:35

GoogleCodeExporter commented 9 years ago

Original comment by vendett...@gmail.com on 25 May 2012 at 12:05

GoogleCodeExporter commented 9 years ago 
Class ScreenManager
"represents the time of the game."
Capitalize. this is repeated several times in the class

"Represents the screen that should be removed from the list
        /// of managed screens by the screenManager."
"...the list of screens managed by..."

You didn't add the author tags. All your methods lack AUTHOR tags, so please 
add them as this is the company's convention.

Original comment by ams.sa...@gmail.com on 25 May 2012 at 12:45

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1849.

Fixed documentation

Original comment by q3a...@gmail.com on 25 May 2012 at 1:11

GoogleCodeExporter commented 9 years ago

Original comment by q3a...@gmail.com on 25 May 2012 at 1:12

GoogleCodeExporter commented 9 years ago 
Class ScreenManager
"Unloads the conent of the screens managed by the screenManager."
content*

"Adds a screen to the list of screens that are managed by the screenManager."
"...screens, managed..."

"Removes a screen from the list of screens that are managed by the 
screenManager."
Same.

"Represents the screen that should be removed from the list
        /// of screens managed by the screenManager."
Same.

Original comment by ams.sa...@gmail.com on 25 May 2012 at 1:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1874.

Fixed documentation

Original comment by q3a...@gmail.com on 25 May 2012 at 2:15

GoogleCodeExporter commented 9 years ago

Original comment by q3a...@gmail.com on 25 May 2012 at 2:16

GoogleCodeExporter commented 9 years ago

Original comment by ams.sa...@gmail.com on 25 May 2012 at 4:21