search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

3.16:As a user I should expect a 3D environment representing the track Im going to race on. #240

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Tasks:
story sequence diagram & artifact
documentation of method
setting up a 3D environment from exp3 library
Changing Skybox and Heightmap
Changing Camera and effect files

Original issue reported on code.google.com by asafty2...@gmail.com on 12 May 2012 at 9:57

GoogleCodeExporter commented 9 years ago

Original comment by asafty2...@gmail.com on 12 May 2012 at 10:11

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r897.

Status: In Progress

Added Environment1.cs, with a 3d environment and called in Experimentnew1.cs

Original comment by asafty2...@gmail.com on 14 May 2012 at 10:51

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r899.

Status: In Progress

Added all Content needed for Exp1(skybox,effect file,and heightmap)

Original comment by asafty2...@gmail.com on 14 May 2012 at 11:03

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r900.

Status: In Progress

Added solution to activate files and content

Original comment by asafty2...@gmail.com on 14 May 2012 at 11:09

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r902.

Status: In Progress

Added Camera initialization to Environment1

Original comment by asafty2...@gmail.com on 14 May 2012 at 11:21

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r903.

Status: In Progress

Added Documentation to Environment1.cs and Experimentnew1.cs

Original comment by asafty2...@gmail.com on 14 May 2012 at 11:41

GoogleCodeExporter commented 9 years ago 
UML and Documentation are Done, Waiting for reviewing

Original comment by asafty2...@gmail.com on 14 May 2012 at 11:45

GoogleCodeExporter commented 9 years ago 
Scenario and Implementation Ready, Waiting for Reviewing

Original comment by asafty2...@gmail.com on 14 May 2012 at 11:49

GoogleCodeExporter commented 9 years ago 
changed from new story to in progress

Original comment by asafty2...@gmail.com on 15 May 2012 at 12:04

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r933.

Status: In Progress

Added Chase Camera to Experiment1.cs (Press K to move from chase to target 
camera :P )

Original comment by asafty2...@gmail.com on 15 May 2012 at 7:15

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1188.

Status: In Progress

Added graph exp1 and winnerscreen screens [screenmanager]

Original comment by asafty2...@gmail.com on 20 May 2012 at 12:43

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1191.

Status: In Progress

[Integration] Added the 2D environment, the 2D avatars, the soundeffects

Original comment by asafty2...@gmail.com on 20 May 2012 at 1:29

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1203.

Status: In Progress

[Integration] Added the orientation to the Countdown

Original comment by asafty2...@gmail.com on 20 May 2012 at 3:14

GoogleCodeExporter commented 9 years ago 
Files attached are the PO email request and his reply, he requests a 2D 
environment and wants it to have a higher priority that the 3D one. so I'm 
asking to change the Issue name to " As a user I should expect a 2D environment 
representing the track Im going to race on".

Safty

Original comment by asafty2...@gmail.com on 20 May 2012 at 6:37

Attachments:

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1232.

Status: In Progress

[Integration] Added track length and the Winning/Graph Screen

Original comment by asafty2...@gmail.com on 20 May 2012 at 8:41

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1240.

Status: In Progress

[Integration] Added Commands from Sprint1 and timeslices

Original comment by asafty2...@gmail.com on 20 May 2012 at 10:45

GoogleCodeExporter commented 9 years ago 
--Review Exp1 class

- the code is impossible to read and can never be reused 

- Classes correct design
UserKnee {
// what i see from the code that each variable in KneeVariables region is 
duplicated so these variables should be grouped in a class
}

Command {
    string name
    int timeSlice
}

Exp1 {
    Environment1 environment
    List<Command> commands
    UserKnee knee1
    UserKnee knee2
}

1 - useless using statements should be removed

2 - List<String> gCommands should be declared static readonly

3 - instance variable that are used locally should be declared private

4 - bool talking should be removed since its not used

5 - the variable names in region KeeVariables are not descriptive 

6 - unused code comments should be removed

7 - in loadcountdown() should be
Texture2D[] numbers = new Texture2D[3];
numbers[0] = Texone = Content.Load<Texture2D>("1");
numbers[1] = Textwo = Content.Load<Texture2D>("2");
numbers[2] = Content.Load<Texture2D>("3");
and class CountDown should be changed to accept it

8 - comm_and_timeslice is not decriptive

9 - in Draw()
if (timer > 4) {} should be removed

-- Review Environ1 class

10 - the class name should be Environment1 

11 - whats the use of CountDown variables

12 - in Update()
the whole if statement should be replaced with
ChantsInstance.IsLooped = false;
ChantsInstance.Play();

13 - long lines should be splitted

14 - c sharp conventions should be followed

Original comment by bishoyba...@gmail.com on 23 May 2012 at 5:51

GoogleCodeExporter commented 9 years ago

Original comment by asamg...@gmail.com on 23 May 2012 at 7:34

GoogleCodeExporter commented 9 years ago 
as per SD @ 
https://docs.google.com/drawings/d/1J1HUm2yw-HLPMCck2FjiAfk4FaF0mLiQ-MLp7wrrVKQ/
edit
*The SD name should be written inside the sequence diagram
*The actor is not a class and couldn't have a return value !!
*the actor lifeline shouldn't have an activation box
*On the arrow of the synchronous messages (or asynchronous) you should write 
the method called with parameters passed not an English description 
*I won't be able to continue reviewing until i can see the methods names
* non of these methods is in class Game1!!

However, The user shouldn't see a rocky 3D environment by any means (it's a 2D 
one)

Original comment by mohamed....@gmail.com on 23 May 2012 at 9:21

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1596.

Status: In Progress

[Integration] Adding Exp1 Cs files to the solution

Original comment by asafty2...@gmail.com on 24 May 2012 at 5:21

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1599.

Status: In Progress

[Integration] added exp1 to the screenManager, now you can navigate from start 
screen to exp1

Original comment by asafty2...@gmail.com on 24 May 2012 at 5:55

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1629.

Status: In Progress

[Integration] Calling Graphs to WinnerScreen.cs , reducing number of Commands 
to 3, adding cumulative time

Original comment by asafty2...@gmail.com on 24 May 2012 at 9:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1636.

Status: In Progress

[Integration] removed spriteBatch to hide the CD when race starts, fixed a bug 
in Winnerscreen ( 2 loops on same person)

Original comment by asafty2...@gmail.com on 24 May 2012 at 9:54

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1638.

Status: In Progress

[Integration] Fixed a bug in knee calculation ( same user was called twice)

Original comment by asafty2...@gmail.com on 24 May 2012 at 10:23

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1665.

Status: In Progress

[Integration] Adjusting lines' length, and Winner display criteria

Original comment by asafty2...@gmail.com on 24 May 2012 at 12:11

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1670.

Status: In Progress

[Integration] fixed user2 condition ( 2 exact players problem) and Hand now 
moves in InstructionsScreen1.cs

Original comment by asafty2...@gmail.com on 24 May 2012 at 12:58

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1674.

Status: In Progress

[Integration] Setting the volume of the crowd and removing the disqualification 
condition to end the race.

Original comment by asafty2...@gmail.com on 24 May 2012 at 1:22

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1680.

Status: In Progress

[Integration] New conditions for Winningscreen

Original comment by asafty2...@gmail.com on 24 May 2012 at 2:01

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1687.

Status: In Progress

[Integration] adjustment for the new resolution concerning the commands

Original comment by asafty2...@gmail.com on 24 May 2012 at 3:04

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1688.

Status: In Progress

[Integration] adjustment for the new resolution concerning the status

Original comment by asafty2...@gmail.com on 24 May 2012 at 3:08

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1700.

Status: In Progress

[Integration] Added Documentation enhancement

Original comment by asafty2...@gmail.com on 24 May 2012 at 3:56

GoogleCodeExporter commented 9 years ago 
add <returns>void: description of what should happen</returns> to methods in 
class Exp1

Original comment by michel.n...@gmail.com on 24 May 2012 at 6:21

GoogleCodeExporter commented 9 years ago 
add <returns>void: description of what should happen</returns> to methods in 
class Winnerscreen and Environ1

In Environ1 please add parameters description for the constructor

Original comment by michel.n...@gmail.com on 24 May 2012 at 6:27

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1742.

Status: In Progress

[Integration] removed sprint 1 files, not needed

Original comment by asafty2...@gmail.com on 24 May 2012 at 8:11

GoogleCodeExporter commented 9 years ago 
I couldn't find any Void description on internet or in our project

Original comment by asafty2...@gmail.com on 24 May 2012 at 9:47

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1770.

Status: In Progress

[Documentation][Implementation] Documentation addition, changed conventions 
according to implementation reviewer's  Issue

Original comment by asafty2...@gmail.com on 24 May 2012 at 9:56

GoogleCodeExporter commented 9 years ago 
it's ok although I'm not convinced and you could've done like what I've done!!

Original comment by michel.n...@gmail.com on 24 May 2012 at 10:10

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1800.

Status: In Progress

[Implementation]Made tools1 public, and added new tests

Original comment by asafty2...@gmail.com on 24 May 2012 at 11:33

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1813.

Status: In Progress

[Documentation][Implementation] Added a Button to the Graphs to return to 
mainmenu

Original comment by asafty2...@gmail.com on 25 May 2012 at 12:41

GoogleCodeExporter commented 9 years ago 
Documentation is ready

Original comment by asafty2...@gmail.com on 25 May 2012 at 1:15

GoogleCodeExporter commented 9 years ago 
The parameters description must end with a "." in WinnerScreen and Exp1, and 
description of method update's parameter in winnerScreen must start with 
capital letters and end with a ".". So please fix them ASAP.

Original comment by michel.n...@gmail.com on 25 May 2012 at 5:10

GoogleCodeExporter commented 9 years ago 
https://docs.google.com/#folders/0B1jnxDwGYMArZnJxVkZBVHBIVm8

UML ready

Original comment by asafty2...@gmail.com on 25 May 2012 at 6:13

GoogleCodeExporter commented 9 years ago 
UML Review:

* The  Convention of naming the SD is as in 
http://www.ibm.com/developerworks/rational/library/content/RationalEdge/feb04/31
01_figure1.jpg
*There is a difference between the user << Actor>> and the User class.
*The user actor cannot return an instance called object !
*The Actor lifeline should have no activation box
*The returned instance should have the name that will be used ,
The lifeline box should be in the form [ Instance Name : Class Name ]
*once more, you should call the the methods not a descriptive sentence
*please use Stereo types <<Actor>>,<<UI>>,<<System>>,.....
Please Fix!

Original comment by mohamed....@gmail.com on 25 May 2012 at 7:49