search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

As a user, I can change the theme, choose difficulty #244

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As a user, I can change the theme, choose difficulty

Tasks : 
1)story sequence diagram & artifact
2)Implement the class of the theme and some helpers
3)Implementing and showing theme pictures
4)Implementing and showing difficulty levels
5)documentation of methods

Original issue reported on code.google.com by hollaxy...@gmail.com on 14 May 2012 at 9:05

GoogleCodeExporter commented 9 years ago 
Implementation and Documentation are ready :) .

Original comment by hollaxy...@gmail.com on 15 May 2012 at 8:49

GoogleCodeExporter commented 9 years ago 
use smart commits

Original comment by 3abdelazim on 17 May 2012 at 12:53

GoogleCodeExporter commented 9 years ago 
smart commits : i use smart commits.However what you mean is linking between 
issue number and issue itself and ok i will do it.

Original comment by hollaxy...@gmail.com on 17 May 2012 at 1:09

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 17 May 2012 at 6:47

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1088.

Removed redunted reference

Original comment by hollaxy...@gmail.com on 17 May 2012 at 10:25

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1090.

Changed draw method to handle Hegazy drawing hand change

Original comment by hollaxy...@gmail.com on 17 May 2012 at 10:30

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 18 May 2012 at 2:40

GoogleCodeExporter commented 9 years ago 
uml : https://docs.google.com/file/d/0B-dUQ-lqzETwaWNkZENTSHZXTDQ/edit

Original comment by hollaxy...@gmail.com on 18 May 2012 at 5:35

GoogleCodeExporter commented 9 years ago 
Going for slight changes ,Implementation is not ready

Original comment by hollaxy...@gmail.com on 20 May 2012 at 9:58

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1239.

changed "update" signature  and calling of drawHand to match new methods names.

Original comment by hollaxy...@gmail.com on 20 May 2012 at 10:29

GoogleCodeExporter commented 9 years ago 
Implementation is ready now.

Original comment by hollaxy...@gmail.com on 20 May 2012 at 10:30

GoogleCodeExporter commented 9 years ago 
as said before, don't use underscore or var
rename u to user
use meaningful names instead of 1,2
for example
instead of rightArrow, rightArrow2
user themesRightArrow, levelRightArrow

Begin spriteBatch once in the draw method, and End it at the last line

Original comment by 3abdelazim on 21 May 2012 at 1:23

GoogleCodeExporter commented 9 years ago 
* Method draw shouldn't be having game time
* constructor shouldn't be having spriteBatch, spriteBatch should be passed as 
a parameter to the draw method
* rename Initialize to LoadContent
* don't put game in the constructor, put it in the LoadContent (anything UI 
related should be put in LoadContent not the Constructor)
* and don't put game because it's too general, put Content only. it's the only 
thing you are using out of it
* Rename screenw and screenh to screenWidth, screenHeigth (for both instance 
variables and method parameters and differentiate between them using this.)
* rename _selected to selectedLevel or something meaningful

Original comment by 3abdelazim on 21 May 2012 at 1:40

GoogleCodeExporter commented 9 years ago 
ok,As we agreed on today that _ will be removed.However var will not be removed.

Original comment by hollaxy...@gmail.com on 21 May 2012 at 4:30

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1278.
fixing code according to zaza review

Original comment by hollaxy...@gmail.com on 21 May 2012 at 6:17

GoogleCodeExporter commented 9 years ago 
fixing uml

Original comment by hollaxy...@gmail.com on 21 May 2012 at 6:25

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1287.

splitting line

Original comment by hollaxy...@gmail.com on 21 May 2012 at 7:14

GoogleCodeExporter commented 9 years ago 
uml : https://docs.google.com/file/d/0B-dUQ-lqzETwR21zclg5dU9WSWc/edit

Original comment by hollaxy...@gmail.com on 21 May 2012 at 7:22

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1565.

Fixed scaling and level selection

Original comment by hollaxy...@gmail.com on 24 May 2012 at 1:21

GoogleCodeExporter commented 9 years ago 
new uml : https://docs.google.com/file/d/0B-dUQ-lqzETwRUk5b3VJTFAtZlU/edit?pli=1

Original comment by hollaxy...@gmail.com on 24 May 2012 at 2:46

GoogleCodeExporter commented 9 years ago 
-Add documentation for the class.
-Remove commented lines
-First letter should be Capital in all documentation
-Spelling mistake in "initilizing" in the documentation of LoadContent method.
-Second update word in the documentation of Update method should be "updates" 
with S in the end. And please, the grammar of the whole sentence is wrong.
-"Draw method that updates the UI frequently". Replace your documentation of 
the Draw method with this.
-

Original comment by mohamedra2fat on 24 May 2012 at 9:11

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1698.

Added SettingsScreen.jpg to Files

Original comment by hollaxy...@gmail.com on 24 May 2012 at 3:53

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1710.

Added the photo in solution

Original comment by hollaxy...@gmail.com on 24 May 2012 at 5:24

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1711.

Added the background in settings + fixing some UI problems

Original comment by hollaxy...@gmail.com on 24 May 2012 at 5:27

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1729 .

Fixed Documentation.

Original comment by hollaxy...@gmail.com on 24 May 2012 at 7:40

GoogleCodeExporter commented 9 years ago 
Commented Lines are used for extending themes in Sprint 3.

Original comment by hollaxy...@gmail.com on 24 May 2012 at 7:41

GoogleCodeExporter commented 9 years ago

Original comment by 3abdelazim on 25 May 2012 at 1:04

GoogleCodeExporter commented 9 years ago

Original comment by mohamedra2fat on 25 May 2012 at 1:56

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 25 May 2012 at 4:47

GoogleCodeExporter commented 9 years ago 
Design Verified, Great Job

Original comment by asafty2...@gmail.com on 25 May 2012 at 7:04

GoogleCodeExporter commented 9 years ago 
forgot to add label :D

Original comment by asafty2...@gmail.com on 25 May 2012 at 7:04

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 25 May 2012 at 7:06