search

khaledosman / terasoft-12

Automatically exported from code.google.com/p/terasoft-12
0 stars 0 forks source link

202:As a user, after the environment is created, I should see a generated hole at a random distance and angle, which I should shoot at. #35

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The method will generate a hole at random distance and angle

Original issue reported on code.google.com by khaled.osmaan on 13 Apr 2012 at 7:08

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 19 Apr 2012 at 3:09

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 21 Apr 2012 at 4:51

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r430.

status inProgress
added some new variables and methods InitializeHole(), LoadHole(), DrawHole() 
and called them in the environment class initializing/loading/drawing methods

Original comment by khaled.osmaan on 24 Apr 2012 at 7:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r431.

status inProgress
added methods GenerateRandomValue(float min, float max) and setHole(float 
min,float max)

Original comment by khaled.osmaan on 24 Apr 2012 at 7:33

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 24 Apr 2012 at 7:38

GoogleCodeExporter commented 9 years ago 
1.if you don't need Unload hole, which i doubt you do, remove it!

2. use var when possible, i think there was 1 time when type was obvious and 
var was not used

Original comment by q3a...@gmail.com on 25 Apr 2012 at 9:35

GoogleCodeExporter commented 9 years ago 
Load Unload Initialize Draw Update methods are necessary in all classes, we 
eventually will unload the environment and thus we'll need to unload the hole 
aswell

Original comment by khaled.osmaan on 25 Apr 2012 at 11:38

GoogleCodeExporter commented 9 years ago 
well I'll remove it for now as long as its empty

Original comment by khaled.osmaan on 25 Apr 2012 at 11:42

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r464.

status inProgress
removed empty method UnloadHole as requested by reviewer

Original comment by khaled.osmaan on 25 Apr 2012 at 11:49

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r467.

status inProgress
edited documentation in class Hole

Original comment by khaled.osmaan on 25 Apr 2012 at 11:54

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 25 Apr 2012 at 11:57

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r469.

status inProgress
method GenerateRandomValue will only run if min, max values are non negative 
numbers, and max is greater than min to avoid any scenario fails

Original comment by khaled.osmaan on 25 Apr 2012 at 12:05

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r473.

status inProgress
method GenerateRandomValue throws exception if condition is not satisfied

Original comment by khaled.osmaan on 25 Apr 2012 at 12:17

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 25 Apr 2012 at 12:44

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r500.

status inProgress
commented line holeModel = Content.Load<Model>(@"Models/holemodel"); since 
Model was not commited yet.

Original comment by khaled.osmaan on 25 Apr 2012 at 4:44

GoogleCodeExporter commented 9 years ago 
Missing model so it doesn't run. Don't make it ready until it is complete and 
tested.

Original comment by ams.sa...@gmail.com on 25 Apr 2012 at 4:51

GoogleCodeExporter commented 9 years ago 
You did not fix the documentation as I asked. And btw, where are my comments?

Original comment by ams.sa...@gmail.com on 25 Apr 2012 at 5:00

GoogleCodeExporter commented 9 years ago 
you did not write any comments on this issue, as I can only delete my comments, 
my gmail also says there were only two comments which were by badr. 
documentation was never reOpened as the issue shows, please recheck

Original comment by khaled.osmaan on 25 Apr 2012 at 5:24

GoogleCodeExporter commented 9 years ago 
you can find this story in class Hole and class Environment3 under the region 
Hole methods, im still waiting your review

Original comment by khaled.osmaan on 25 Apr 2012 at 5:28

GoogleCodeExporter commented 9 years ago 
attached is a screenshot for my gmail history for this issue

Original comment by khaled.osmaan on 25 Apr 2012 at 5:32

Attachments:

GoogleCodeExporter commented 9 years ago 
My bad commented on the wrong issue.
Draws the 3D hole by rendering each effect in each mesh in the hole model
Period.
generates a random float value between two float numbers.
capitalize
Takes the minimum and maximum possible values for the x,y,z positions of the 
hole and it's radius then initializes the hole with random values between these 
two numbers
period

Original comment by ams.sa...@gmail.com on 25 Apr 2012 at 5:37

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r505.

status inProgress
added a '.' to /// Draws the 3D hole by rendering each effect in each mesh in 
the hole model as requested by reviewer

Original comment by khaled.osmaan on 25 Apr 2012 at 5:42

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r506.

status inProgress
updated documentation in class Hole as requested by reviewer

Original comment by khaled.osmaan on 25 Apr 2012 at 5:43

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r509.

status inProgress
Committed holemodel.FBX

Original comment by khaled.osmaan on 25 Apr 2012 at 7:20

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r535.

status inProgress
uncommented lines holeModel = Content.Load<Model>(@"Models/holemodel"); and 
hole = new hole()

Original comment by khaled.osmaan on 25 Apr 2012 at 10:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r549.

status inProgress
added new method SetRadius

Original comment by khaled.osmaan on 26 Apr 2012 at 9:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r558.

status inProgress
added variable environment, removed parameters from method SetHoleValues to set 
the x,y,z values in the terrain generated from the environment and updated 
documentation, also removed method SetRadius since radius was already 
implemented as a field with set and get methods

Original comment by khaled.osmaan on 26 Apr 2012 at 10:26

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r559.

status inProgress
changed Position.Z to generate value between 0 and Terrain's Z length/2 to 
leave some space between the hole and shooting position

Original comment by khaled.osmaan on 26 Apr 2012 at 10:30

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r560.

status inProgress
as a change in class Hole, changed the line calling method SetHoleValues to 
pass no parameters to match the new method design

Original comment by khaled.osmaan on 26 Apr 2012 at 10:34

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r566.

status inProgress
added method DrawHole(Camera cam), 
Edited Hole constructor to take ContentManager, GraphicsDevice, terrainWidth, 
terrainHeight, radius as parameters
removed parameters from method SetHoleValues

Original comment by khaled.osmaan on 26 Apr 2012 at 11:17

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r581.

status inProgress
updated class Environment3 to match the updates done in class hole, the hole 
model and its drawing methods are in class Hole, used common class CustomModel 
for better implementation design

Original comment by khaled.osmaan on 26 Apr 2012 at 1:31

GoogleCodeExporter commented 9 years ago 
reopened design without mentioning why..
doesn't show interaction with other classes used, should show other methods 
implemented which are not shown on diagram... diagram not updated with latest 
implementation

Original comment by khaled.osmaan on 26 Apr 2012 at 9:27

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 27 Apr 2012 at 9:55

GoogleCodeExporter commented 9 years ago 
fixed

Original comment by khaled.osmaan on 27 Apr 2012 at 1:03

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r667.

status inProgress
edited documentation for GenerateRandomValue()

Original comment by khaled.osmaan on 27 Apr 2012 at 1:34

GoogleCodeExporter commented 9 years ago 
Message sequence not correct, Duplicate calling for method Draw(cam)

Original comment by khaled.osmaan on 27 Apr 2012 at 3:06

GoogleCodeExporter commented 9 years ago 
fixed

Original comment by khaled.osmaan on 27 Apr 2012 at 3:07

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 27 Apr 2012 at 3:07

GoogleCodeExporter commented 9 years ago 
The camera needed to draw the 3d model
"."
Change order of the tags to this, to follow conventions:
1- summary
2- remarks (author)
3- parameters
4-return
of course any of them that doesn't exist is not written as usual.

Original comment by ams.sa...@gmail.com on 27 Apr 2012 at 5:06

GoogleCodeExporter commented 9 years ago 
Forgot to reopen in the previous comment.

Original comment by ams.sa...@gmail.com on 27 Apr 2012 at 5:07

GoogleCodeExporter commented 9 years ago 
Shouldn't the hole be an actual hole in the environment, not just a circular 
model?

Original comment by ams.sa...@gmail.com on 27 Apr 2012 at 5:08

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r712.

status inProgress
fixed documentation as requested by reviewer

Original comment by khaled.osmaan on 27 Apr 2012 at 5:21

GoogleCodeExporter commented 9 years ago 
this story is underestimated it was given 3 points as it was supposed to only 
generate random values for hole position, it says the user should see the hole 
and he does see it in correct random position, updating the environment is an 
extra

Original comment by khaled.osmaan on 27 Apr 2012 at 5:22

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r721.

status inProgress
fixed documentation as requested by reviewer

Original comment by khaled.osmaan on 27 Apr 2012 at 5:33

GoogleCodeExporter commented 9 years ago 
1. Added variables to environment3 that are not private?!

2. A lot of wrong methods exists in class Environment3. For example, 
DrawHole()..

hole is an instance varibale, so to draw the hole, i expect a method Draw 
inside class hole so i would just write hole.Draw(), this applies to a lot of 
other methods so please check them up

3. this.shootingPosition = shootingPosition; in class hole, totally useless, 
right?

4. Method names should be consistent with those used in the project. For 
example, you use DrawHole() instead of Draw(), InitializeHole() instead of 
Initialize()..

5. Having a constructor and Initialize method is just useless.

6. GenerateRandomValue should be a static method in a static class, like 
Tools3, because it's unrelated to the class and would also give anyone else the 
ability to use it

Original comment by q3a...@gmail.com on 27 Apr 2012 at 6:43

GoogleCodeExporter commented 9 years ago 
2. I dont get it, thats exactly what DrawHole() does it calls hole.Draw()
3. I didn't add this, I think you did when you were doing your dummy 
initializations in the integration meeting, please tell me whether I should 
keep it or not
4. I used DrawHole and InitializeHole to differentiate them from class 
Environment's own Initialize and Draw methods, DrawHole and InitializeHole 
methods call the draw and initialize methods from class hole which 
draws/initializes the custom model and hole variables.
6. I once suggested that but I wasn't given an answer... the whole company has 
to agree on that as it wasn't agreed on as a common story/method

Original comment by khaled.osmaan on 27 Apr 2012 at 6:54

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r754.

added shootingPosition = shootingPos ; in constructor

Original comment by khaled.osmaan on 27 Apr 2012 at 8:54

GoogleCodeExporter commented 9 years ago

Original comment by ams.sa...@gmail.com on 27 Apr 2012 at 9:26

GoogleCodeExporter commented 9 years ago

Original comment by ams.sa...@gmail.com on 27 Apr 2012 at 9:32

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 12 May 2012 at 9:43