Open GoogleCodeExporter opened 9 years ago
This issue was updated by revision r864.
changed game instructions
Original comment by khaled.osmaan
on 14 May 2012 at 6:36
This issue was updated by revision r865.
fixed documentation as requested by reviewer
Original comment by khaled.osmaan
on 14 May 2012 at 6:41
Original comment by khaled.osmaan
on 14 May 2012 at 6:41
This issue was updated by revision r1209.
added button.Draw() after calling spriteBatch.begin() to follow hegazy's
updates as his deprecated method says
Original comment by khaled.osmaan
on 20 May 2012 at 6:16
This issue was updated by revision r1210.
edited documentation
Original comment by khaled.osmaan
on 20 May 2012 at 6:18
This issue was updated by revision r1211.
followed a new change in common method in class GameScreen as it was deprecated
Original comment by khaled.osmaan
on 20 May 2012 at 6:20
This issue was updated by revision r1325.
Changed AddScreen to LoadScreen to match changes in class ScreenManager and
added AddScreen including my screen names in class ScreenManager
Original comment by khaled.osmaan
on 22 May 2012 at 7:07
Class GameScreen
/// <summary>
/// Updates the screen.
/// </summary>
/// <param name="gameTime">represents the time of the game.</param>
/// khaled salah
Capitalize "represents" and why is "khaled salah" written without a tag?
Class Instruction
"This is the main type for your game"
Add a '.' and lacks an author tag
"Constructor of the class Instruction, Sets"
Where is the rest of the sentence. Sets what?
"Author: Mohamed Raafat & Khaled Salah"
"AUTHOR:"
The last two comments are repeated again.
"LoadContent will be called only once before drawing and its the place to load"
it's instead of its
"along with an ok button down the screen."
What does ""down the screen" mean? Please make it more clear.
Some tags have no space between them and the /// Please make sure to add this
space.
Original comment by ams.sa...@gmail.com
on 23 May 2012 at 12:50
class variables should be private
removed unused usings
initialize class variables inside a constructor or Initialize method
don't write lines inside a constructor that are inside another constructor, use
:this() to refer to the old constructor
Original comment by q3a...@gmail.com
on 23 May 2012 at 1:30
This issue was updated by revision r1442.
Commented drawing the button since each screen should have its own button now..
Original comment by khaled.osmaan
on 23 May 2012 at 2:50
This issue was updated by revision r1443.
Updated screen with the new instructions texture, new Button and used the new
constructor in class Instruction to draw my text
Original comment by khaled.osmaan
on 23 May 2012 at 2:51
This issue was updated by revision r1445.
edited the instructions
Original comment by khaled.osmaan
on 23 May 2012 at 2:57
This issue was updated by revision r1472.
fixed some stuff as requested by reviewers
Original comment by khaled.osmaan
on 23 May 2012 at 5:03
sanad, you're reviewing a different class my work is in class
InstructionsScreen3, class Instruction is another story from sprint1
Original comment by khaled.osmaan
on 23 May 2012 at 5:04
This issue was updated by revision r1473.
fixed an error
Original comment by khaled.osmaan
on 23 May 2012 at 5:10
This issue was updated by revision r1534.
editing the string, added 3 new sprite fonts for header's random text and
titles, don't use class Instruction anymore
Original comment by khaled.osmaan
on 23 May 2012 at 10:25
This issue was updated by revision r1536.
Commiting three new fonts
Original comment by khaled.osmaan
on 23 May 2012 at 10:26
This issue was updated by revision r1538.
commiting solution file
Original comment by khaled.osmaan
on 23 May 2012 at 10:28
This issue was updated by revision r1542.
edited string to show it to cena and sanad
Original comment by khaled.osmaan
on 23 May 2012 at 10:35
This issue was updated by revision r1555.
split the string into 4 strings with different fonts/colors for headers/texts
and titles
Original comment by khaled.osmaan
on 23 May 2012 at 11:23
This issue was updated by revision r1557.
edited color codes
Original comment by khaled.osmaan
on 23 May 2012 at 11:28
This issue was updated by revision r1558.
changed font sizes
Original comment by khaled.osmaan
on 23 May 2012 at 11:29
This issue was updated by revision r1597.
fixed some warnings
Original comment by khaled.osmaan
on 24 May 2012 at 5:25
[deleted comment]
This issue was updated by revision r1667.
made variables for UI components instead of calling them from screenManager
everytime
Original comment by khaled.osmaan
on 24 May 2012 at 12:31
Original comment by khaled.osmaan
on 24 May 2012 at 4:36
This issue was updated by revision r1723.
Used method WriteText instead of hardcoding each string
Original comment by khaled.osmaan
on 24 May 2012 at 6:54
Original comment by khaled.osmaan
on 24 May 2012 at 6:55
This issue was updated by revision r1833.
removed contentManager from the parameter of the method UI.Write to match the
newest updates of the method showed by deprecation
Original comment by khaled.osmaan
on 25 May 2012 at 11:13
Original comment by ams.sa...@gmail.com
on 25 May 2012 at 12:11
This issue was updated by revision r1879.
updated documentation
Original comment by khaled.osmaan
on 25 May 2012 at 2:27
This issue was updated by revision r1880.
removed unused variables
Original comment by khaled.osmaan
on 25 May 2012 at 2:37
use parantheses in arithmatic operations
a lot of lines are longer than 120
some parts of the code(strings) looking UGLY!!!!, you can use \t for tab
instead of tons of spaces inside your strings. i can't even read the code :D
Original comment by q3a...@gmail.com
on 25 May 2012 at 5:20
I tried using \t but it made an exception in raafat's method saying invalid
character so I had to add spaces myself
Original comment by khaled.osmaan
on 25 May 2012 at 5:30
This issue was updated by revision r1910.
broke long lines into two
Original comment by khaled.osmaan
on 25 May 2012 at 5:41
Original comment by khaled.osmaan
on 25 May 2012 at 5:42
Original issue reported on code.google.com by
khaled.osmaan
on 13 Apr 2012 at 7:10