khaledosman / terasoft-summer-reunited

Automatically exported from code.google.com/p/terasoft-summer-reunited
0 stars 0 forks source link

K1 : As a user, I can physically jump to cause my avatar to jump. #11

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
As a user, I can physically jump to cause my avatar to jump.

Original issue reported on code.google.com by hollaxy...@gmail.com on 25 Jul 2012 at 8:49

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 1 Aug 2012 at 7:27

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r83.

Added the implementation of jump.However eqn for elevation angle still needed 
to be added

Original comment by hollaxy...@gmail.com on 3 Aug 2012 at 10:52

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r124.

Fixed the implementation of Jump + fixing kinect bug

Original comment by hollaxy...@gmail.com on 6 Aug 2012 at 1:59

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r132.

Fixed bug in jump detection + setting jump and swaphand flags

Original comment by hollaxy...@gmail.com on 6 Aug 2012 at 8:36

GoogleCodeExporter commented 9 years ago
Move your work to a new class called Jump for example so that the code looks 
better, class Kinect should be independent and uesd only for calling other 
methods needed to detect the gestures like it is with swapHand
Also remove your testing lines
if(list.count==10)
{
bla
  list.Add(trackedSkeleton.Joints[JointType.AnkleRight].Position.Y);
}
else
    list.Add(trackedSkeleton.Joints[JointType.AnkleRight].Position.Y);
if (list2.Count == 10)
            {
                list2.Add(trackedSkeleton.Joints[JointType.AnkleLeft].Position.Y);
            }
            else
                list2.Add(trackedSkeleton.Joints[JointType.AnkleLeft].Position.Y);
if else parts with the same lines? take them out..
list[9] >= average / 1.2 && list2[9] >= average2 / 1.2
what does the value 1.2 represent? shouldn't be a certain fraction / relation 
between new and old skeleton positions? and if not add it to class Constants 
and use it from there

Original comment by khaled.osmaan on 14 Aug 2012 at 9:52

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r231.

update issue 12
update issue 14 
update issue 15
update issue 17 
update issue 18
fixed some conventions

Original comment by hollaxy...@gmail.com on 14 Aug 2012 at 9:54

GoogleCodeExporter commented 9 years ago
1)This array is of size 10 ,frames save in that array,once new frame ready,you 
remove last frame,so how you ask to remove else part and remove the  
list.RemoveAt(0); statement,lol

2)You did  not look accurately  on "list[9] >= average / 1.2 " cant you see 
that this is relation ? is this something multiple of something or not :D ? i 
am comparing average with last frame if bigger than 1.2 of it like saying ex : 
2 times ,this is 1.2 times

I agree on using it from constants

Original comment by hollaxy...@gmail.com on 14 Aug 2012 at 10:06

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 14 Aug 2012 at 10:06

GoogleCodeExporter commented 9 years ago
you didnt get the point... 
whats the point of having an if else statement with a lines in both the if and 
the else part? remove them from both and add it outside..
for example:
if(tamer=true)
*bla bla*
System.out.println("hi");
else
*bla bla*
System.out.println("hi");

solution:
if(tamer=true)
{
*bla bla*
}
else
{
*bla bla*
}
System.out.println("hi");

Original comment by khaled.osmaan on 14 Aug 2012 at 10:12

GoogleCodeExporter commented 9 years ago
ok i will do it.Thanks

Original comment by hollaxy...@gmail.com on 14 Aug 2012 at 10:14

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r233.

Accessed the fraction from Constants.cs

Original comment by hollaxy...@gmail.com on 14 Aug 2012 at 10:34

GoogleCodeExporter commented 9 years ago
use the method called Fill_Joints_Pos() 

Original comment by khaled.osmaan on 17 Aug 2012 at 10:30

GoogleCodeExporter commented 9 years ago
what is this method supposed to do :D ?

Original comment by hollaxy...@gmail.com on 17 Aug 2012 at 11:19

GoogleCodeExporter commented 9 years ago
its a magic method :P... you give it the skeleton, the joint you want to track 
and a string with "x" or "y" or "z" and it returns you a List<double> which is 
filled with the joint's x/y/z position as you specified in the parameter :D

Original comment by khaled.osmaan on 17 Aug 2012 at 11:26

GoogleCodeExporter commented 9 years ago
the list count is 10, it stores 10 frames, and removes duplicate values, IE if 
the next two entries in a list are the same it removes one of them

Original comment by khaled.osmaan on 17 Aug 2012 at 11:27

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
@5aled... did u test this method?

Original comment by vendett...@gmail.com on 17 Aug 2012 at 9:20

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r334.

fixed false detection of jump

Original comment by hollaxy...@gmail.com on 18 Aug 2012 at 3:55