search

khalidabuhakmeh / ConsoleTables

Print out a nicely formatted table in a console application C#
MIT License
944 stars 157 forks source link

Update to csproj tooling. #14

Closed vcsjones closed 7 years ago

vcsjones commented 7 years ago

This adds .NET Framework 4.5 support and netstandard1.3. Using dotnet build will build both. The nuspec has been merged into the csproj.

vcsjones commented 7 years ago

So, a few thoughts based on this issue: https://github.com/khalidabuhakmeh/ConsoleTables/issues/12

trying to go for netstandard1.2

System.Console is netstandard1.3 only, so I think 1.2 is unrealistic, and frankly it's near impossible to build a Console application < 1.3. 1.2 and below is more for library authors that don't depend on a project type. You could change your code to write to a TextWriter instead of directly to the Console, then have consumers pass in the Console.Out stream. This may be beneficial if someone wants to pass in Console.Error instead. However, I think this is mostly just going to be friction for some people.

net40

The reflection APIs are vastly different in .NETStandard. 4.5 matches them. I'm not 100% sure of the best way to target 4.0 with the reflection APIs without tacky ifdef.

khalidabuhakmeh commented 7 years ago

Fair enough, this is a major version bump anyways :)