search

khamusa / rspec-graphql_matchers

Collection of rspec matchers to test your graphQL api schema.
MIT License
145 stars 49 forks source link

Add support for underscored argument names in accept_argument(s) #32

Closed TonyArra closed 4 years ago

TonyArra commented 4 years ago

Allows for underscored argument names in the accept_argument and accept_arguments matchers.

khamusa commented 4 years ago

Hey @TonyArra, thanks for the Pull Request! I'll take some time to look at this as soon as possible. In the meanwhile, can you fix the codeclimate issues for too long lines? Thx!

TonyArra commented 4 years ago

Hey @TonyArra, thanks for the Pull Request! I'll take some time to look at this as soon as possible. In the meanwhile, can you fix the codeclimate issues for too long lines? Thx!

Hey @khamusa, I see that the Travis build passed, and there's a Details link to view the build. but for codeclimate, all I see is "codeclimate Expected — Waiting for status to be reported" with no link. Is there a way for me see the codeclimate issues?

TonyArra commented 4 years ago

@khamusa I was able to analyze the branch on my fork and fixed the issues