search

khamusa / rspec-graphql_matchers

Collection of rspec matchers to test your graphQL api schema.
MIT License
145 stars 49 forks source link

Update to use #to_type_signature instead of #to_graphql #43

Closed RobinDaugherty closed 1 year ago

RobinDaugherty commented 2 years ago

graphql 1.13.1 deprecated #to_graphql, making this change necessary.

#to_type_signature seems to have been added in ruby-graphql 1.8.3 so this shouldn't be a breaking change for most users.

BoboFraggins commented 2 years ago

This fixes #42 for us.

RobinDaugherty commented 2 years ago

@khamusa can you please merge and release this? Please let me know if I can help.

Sh1ken commented 2 years ago

Is this the only change holding this gem back from upgrading to GraphQL-Ruby 2.0?

MrJoy commented 2 years ago

The version range for graphql in the gemspec also needs to be updated, at the very least.

djberg96 commented 2 years ago

Is this the only change holding this gem back from upgrading to GraphQL-Ruby 2.0?

Some of the specs will need to be updated as well.

Edit: and this line doesn't work with 2.x: https://github.com/khamusa/rspec-graphql_matchers/blob/master/lib/rspec/graphql_matchers/types_helper.rb#L9

liveh2o commented 1 year ago

Just starting a new gig, and seeing these deprecation warnings. What's the status on this MR? I'd love to help if I can.

tdgs commented 1 year ago

Any news on this one?

tdgs commented 1 year ago

@khamusa thanks for writing this gem! Are you still actively maintaining this?

phikes commented 1 year ago

I am trying to get a hold of @khamusa via other channels to take over maintaining of this gem.

khamusa commented 1 year ago

Thanks for all the contributions, and I apologize for disappearing.

I have merged the PR, fixed the tests, did some extra cleanup, and updated the gemspec versions after testing against all minor versions. Version 1.4.0 has been published. I'll now investigate what's needed to achieve compatibility with graphql-ruby 2+

phikes commented 1 year ago

Amazing, welcome back und thanks for putting in the work :)