search

khan4019 / tree-grid-directive

Need one or more maintainer for this! comment or email me if you are interested
http://khan4019.github.io/tree-grid-directive/test/treeGrid.html
347 stars 183 forks source link

tree_icon improvement #151

Open julievalet opened 6 years ago

julievalet commented 6 years ago

Hello there,

I am using this library for a work project and found improvements that are useful to me, so maybe you'll find them useful for others.

First, I find out you can write icon-leaf="null" to have no icon for leaves. So I removed the link when there is no icon. (https://github.com/khan4019/tree-grid-directive/commit/997c0b01fda22f8b5458df2a3aa666fe59a6d89a)

Then, I added the possibility to have an icon for the roots. (https://github.com/khan4019/tree-grid-directive/commit/37da0272c964aa5847ce7065c6a02e3e4345b3e8) In my project, the children are loaded after a server-side request, so I need to have an icon for the roots regardless if they have any children. When clicked it will send the request.

Thanks for reviewing my pull request. ;)