When use PHP 8.1 got warning: PHP Deprecated: Implicit conversion from float xx to int loses precision

khanamiryan / php-qrcode-detector-decoder

This is a PHP library to detect and decode QR-codes. This is first and only QR code reader that works without extensions.

Apache License 2.0

1.38k stars 324 forks source link

When use PHP 8.1 got warning: PHP Deprecated: Implicit conversion from float xx to int loses precision #118

Open exculibar opened 2 years ago

exculibar commented 2 years ago

PHP Deprecated: Implicit conversion from float 97.5 to int loses precision in /vagrant/hen/vendor/khanamiryan/qrcode-detector-decoder/lib/Common/BitMatrix.php on line 449

PHP Deprecated: Implicit conversion from float 2.0444444444444443 to int loses precision in /vagrant/hen/vendor/khanamiryan/qrcode-detector-decoder/lib/Qrcode/Decoder/DecodedBitStreamParser.php on line 239

exculibar commented 2 years ago

According to PHP 8.1 standard I fixed it temporarily using (int) cast

albertbrufau commented 2 years ago

Also in vendor/khanamiryan/qrcode-detector-decoder/lib/Common/HybridBinarizer.php line 148