khanhas / AppVolumePlugin

Plugin for Rainmeter: Get and control apps volume, peak.
GNU General Public License v3.0
33 stars 3 forks source link

Memory Leak #2

Closed Mor3bane closed 5 years ago

Mor3bane commented 5 years ago

Whilst running appvolume 1.1 I noticed that over time - and by way of association my memory usage spiked over the course of 24 hours. This included even more in swap memory. Eventually I got a memory hex code and Rainmeter shut down. Even since I restarted I am seeing an increase in swap usage and lack of it returning to normal as usual when certain programs are closed after being done with them - games for example. If i get the pop up again i will screenshot it. Hopefully you still monitor this.

Mor3bane commented 5 years ago

Just now I started appvolume1.1 and my swap usage just spike by 2 gig!! it is NOT going down so it is not an incidental spike.

Mor3bane commented 5 years ago

Hello again, I am back to ask another question - in the hopes you will respond... How could "master" volume be added as an option to this? I am having loads of fun messing around, but I cannot figure out the "master" volume. Any help would be appreciated!

khanhas commented 5 years ago

Hi, I'm investigating + refactoring part of my code so hang on. About master volume, you can use Rainmeter in-built Win7Audio plugin: https://docs.rainmeter.net/manual-beta/plugins/win7audio/

Mor3bane commented 5 years ago

Awesome!

Mor3bane commented 5 years ago

Hi, I'm investigating + refactoring part of my code so hang on. About master volume, you can use Rainmeter in-built Win7Audio plugin: https://docs.rainmeter.net/manual-beta/plugins/win7audio/

Hey khanhas, thanks for coming in. I am lost on implementing the win7audio plugin within your structure e.g. having your bars show the master volume. I understand the basic of the win7audio plugin but not in this format. What I mean is I dont know where to start... Should I build it in the S[n] K[n] section, or create a meter? My attempts are not working. I wont annoy you with the incorrect code :P Thanks for any help!

khanhas commented 5 years ago

AppVolumeExampleSkin.zip Try this one.

Basically, I made a shape and a text meter that have same styles as Apps, then put it on top of apps meters. In shape meter, I used MasterVolCalc as scale value instead of AppVolXX as other apps. I also expanded background, modified position of generated meters (S3K3).

image

Mor3bane commented 5 years ago

Thanks, now it seems so obvious - I was over complicating things.

THANKS for the help khanhas.

khanhas commented 5 years ago

Also, try this plugin version and tell me if it's still leaking memory: AppVolume_x64_dll.zip Extracts the dll to %appdata%\Rainmeter\Plugins\ Remember to exit Rainmeter first.

Mor3bane commented 5 years ago

Well, I see an immediate difference in Physical Memory being more stable. Swap 'may' still be leaking, and without chrome running Swap looked pretty good, but it jumped a bit high after chrome opened - which is weird since i am not running a tab with sound - I'll try that now... I opened Netflix and there was no spike worth mentioning. If anything looks gooey after a while, I'll update you.

This thing is SO COOL for Rainmeter. I can make it prettier than "sndvol.exe" and it functions the same - which is what makes your plugin totally worth keeping up on screen. (I have 6 1920x1080's so my Rainmeter is running tonnes of things...)

Thanks again khanhas!

Mor3bane commented 5 years ago

untitled

khanhas commented 5 years ago

Fixed in v1.2.0