search

khanhas / genius-spicetify

Fetch lyrics from Genius and Musixmatch right in Spotify desktop client
258 stars 12 forks source link

Nothing on Genius page #3

Closed federico-ntr closed 4 years ago

federico-ntr commented 4 years ago

Hi, I followed the instructions in the readme to set up genius in spicetify-cli. I get no errors during the process but when I open the genius app nothing appears. I'm on Manjaro GNOME with latest stable packages and Spotify installed via flatpak.

genius page screen

khanhas commented 4 years ago

Can you restart Spotify then open DevTool Console, see if there is any error.

federico-ntr commented 4 years ago

I started Spotify, opened DevTool Console then opened genius app. It shows me four warnings, three of which seem to be related to genius app. I'll attach a screen

genius app warnings

Edit, I actually realized that only one is related to genius app. I tried to do some research but I guess it's beyond my knowledge. By the way, I see flatpak version is more updated than AUR one (1.26 vs 1.10). Maybe you tested with AUR version and the problem is related to a Spotify update? I don't know, shot in the dark here.

I'll try installing AUR version and update here as soon as I can.

khanhas commented 4 years ago

I installed spotify-dev package which is v1,26 right now so version is not problem. Also these warnings are harmless, they won't stop app from loading. Can you open Spotify director, go to Apps folder and check if there is genius symlink there? And does it lead to correct folder?

federico-ntr commented 4 years ago

I confirm that genius symlink is there and it seems to point to the right folder. Screenshot attached

genius symlink EDIT: I don't know why that text is selected, I didn't mean to put attention there EDIT 2: I'm sorry, I'm dumb and I didn't realize that it's all written in Italian.

Tipo: Collegamento a Cartella = Type: Link to Directory
Collegamento a: /home/.../genius = Link to: /home/.../genius
Contenuto: 99 oggetti, in totale 1,9 MB = Content: 99 objects, 1,9 MB in total
Cartella superiore: admin:///.../spotify/Apps = Parent directory: admin:///.../spotify/Apps

Then there are last edit timestamp and free disk space, I guess they're useless here. I'm really sorry for how dumb I am. I hope this is undestandable with a litheral translation and my poor English skills.

federico-ntr commented 4 years ago

Sorry for double posting, just wanted to report that I installed the aur version (spotify-dev, so same Spotify version as you already stated before) and this custom app works just fine on it. Maybe it's something related to flatpak confinement? Don't know, by the way I'm available for testing if you have any idea .

khanhas commented 4 years ago

I think that could be it, flatpak prevents programs to access stuff outside of its directory. That's why Spotify could not use the symlink to custom apps spicetify puts in there

khanhas commented 4 years ago

I will add an option for Spicetify to copy custom apps instead of symlinks.

swingcake commented 4 years ago

Hi, I followed the instructions in the readme to set up genius in spicetify-cli. I get no errors during the process but when I open the genius app nothing appears.

@khanhas Same issue on WIndows 10.

However, Musixmatch works perfectly.

Edit: Incidentally enough, I applied Dribbblish theme, and Genius page is no longer blank. It displays the lyrics now but is static (does not highlight the current line). I don't know if that's the intended behaviour. Musixmatch works fine here as it was earlier, highlighting the current part of the song.

I think it has something to do with the following command: spicetify config inject_css 1 replace_colors 1 overwrite_assets 1

khanhas commented 4 years ago

@swingcake fixed in latest commit. Please git pull to update

swingcake commented 4 years ago

@khanhas I git pull, do I need to spicetify apply or simply restart Spotify or does it work on-the-fly?

Also;

..I applied Dribbblish theme, and Genius page is no longer blank. It displays the lyrics now but is static (does not highlight the current line). I don't know if that's the intended behaviour.

I think it has something to do with the following command: spicetify config inject_css 1 replace_colors 1 overwrite_assets 1

Comments on this?

Thanks

stankovictab commented 4 years ago

It just started working for me by doing spicetify apply and spicetify update, did not need to pull

federico-ntr commented 4 years ago

By the way, my issue was different. When I wrote

when I open the genius app nothing appears. I meant the whole app, including musixmatch. Clicking on "Genius" in the sidebar resulted in a blank screen and I couldn't even choose Genius or Musixmatch. The issue I had is probably related to flatpak confinement, because installing from AUR everything is fine. I think flatpak issue requires a change on spicetify app, but just a guess.

khanhas commented 4 years ago

@holoitsme I wrote a guide to override flatpak filesystem. If you have time, can you try it out: https://github.com/khanhas/spicetify-cli/wiki/Guide-for-Flatpak-user#using-custom-apps-and-node_modules If this works, I don't I need to change anything on spicetify, less hairy code.

federico-ntr commented 4 years ago

@khanhas sorry for the late response, I just tried and it works perfectly! Congrats!