search

khanhduzz / matcha

Matcha 🍃 - a microservices shopping system
MIT License
4 stars 3 forks source link

[Product] CRUD for product module #2

Open khanhduzz opened 1 month ago

khanhduzz commented 1 month ago
PALASH2201 commented 1 month ago

Can you assign this issue to me? @khanhduzz

khanhduzz commented 1 month ago

Can you assign this issue to me? @khanhduzz

That’s great! You can break it into many small pull requests for easier review. @Ngleanthu

PALASH2201 commented 1 month ago

@khanhduzz why are assigning it to other person? My tag is @PALASH2201

khanhduzz commented 1 month ago

@khanhduzz why are assigning it to other person? My tag is @PALASH2201

Oh, sorry, just a mistake, I can give you this first @PALASH2201

khanhduzz commented 1 month ago

@PALASH2201 You can fork this to contribute. I’d love to see your code first before inviting you to become one of our contributors. We have to follow the check-style code and also RESTful API. Thanks!

PALASH2201 commented 1 month ago

@khanhduzz Yea, no worries, will get into the code

PALASH2201 commented 1 month ago

@khanhduzz I can't find the spring security file. Have you done the configuration? Because when I hit the post endpoint, it says 401 unauthorized

khanhduzz commented 1 month ago

@khanhduzz I can't find the spring security file. Have you done the configuration? Because when I hit the post endpoint, it says 401 unauthorized

I’m on it. However, these days are quite busy for me. I will integrate Keycloak and security soon. I’ll notify you when I’m done. Please wait, thanks! @PALASH2201

PALASH2201 commented 1 month ago

@khanhduzz I added a Spring Security file which permits all requests for now, later we can config it according to the requirements. I have started implementing the CRUD operations, and also I have used "@GeneratedValue" annotation for Product ID and changed the datatype to long. Is it alright? I have not committed any code. Just giving you heads up

khanhduzz commented 1 month ago

It's sound great! @PALASH2201

PALASH2201 commented 1 month ago

@khanhduzz I have completed the CRUD operations on Product which includes creating a product , updating product by id , deleting product by id , get product by id, get all products. I have also added .env file to store the username , password, and url of database instead of hardcoding them. So should I open up a PR? What about the test cases?

PALASH2201 commented 1 month ago

@khanhduzz Should I open up a PR?

khanhduzz commented 1 month ago

Oh, I miss it, sorry! That's fine @PALASH2201

PALASH2201 commented 1 month ago

@khanhduzz I have issued a PR for same, please review and provide feedback for same