Implemented CRUD operations for Product Module

PALASH2201 commented 1 month ago

Issue: #2 This PR introduces the following features to the project:

RESTful APIs for Product Module:

Implemented CRUD (Create, Read, Update, Delete) operations for managing products.
Endpoints created:
- POST /api/products Create a new product.
- GET /api/product: Retrieve a list of all products.
- GET /api/product/id/{id}: Retrieve a specific product by ID.
- PUT /api/product/id/{id}: Update an existing product by ID.
- DELETE /api/product/id/{id}: Delete a product by ID.
Utilized best practices for API design and ensured proper response codes and messages.
1. Spring Security Integration:
  - Integrated Spring Security to provide a foundational layer of security for the application.
  - Currently, all endpoints are secured using a basic auth username (user) and a password generated in console.
  - Future iterations will include role-based access control and secure endpoints.

Testing:

Manual testing performed using Postman to verify API responses and status codes.

Notes:

Please review the code changes and provide feedback. I look forward to suggestions for improvements, especially concerning the security configuration. Thank you for considering this PR!

PALASH2201 commented 1 month ago

@khanhduzz Can you approve the further checks?

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...n/java/com/fjb/product/service/ProductService.java	0.00%	20 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines	Coverage Δ	Complexity Δ
...n/java/com/fjb/product/service/ProductService.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`

... and 3 files with indirect coverage changes

khanhduzz commented 1 month ago

I’m swamped with deadlines at the company right now. I’m working on integrating Keycloak with Swagger and adding security to our services, so it might take me a bit longer to review your code. Please bear with me! Thank you @PALASH2201.

PALASH2201 commented 1 month ago

@khanhduzz I have pulled the latest changes, any configurations I have to make in my local machine to run the latest changes?

khanhduzz commented 1 month ago

@PALASH2201 I have already setup some container and we will be able to run with Swagger, I will up a guideline tomorrow! So, you can follow it and run the project

PALASH2201 commented 1 month ago

Ok, thanks!

khanhduzz commented 1 month ago

@PALASH2201 Hi Palash, I've updated the wiki with instructions on how to run the project. Please take a look!

PALASH2201 commented 1 month ago

@khanhduzz Ok, I'll look into it.

PALASH2201 commented 1 month ago

@khanhduzz I have tested it, working fine. Actually, I had a doubt about the try catch block in Controller , can you provide some sample as how do you want the exceptions to be handled?

khanhduzz commented 1 month ago

@PALASH2201

It's okay, but I think it will take some time to finish. I will implement the ExceptionHandler in the Product module soon!
Btw, If you have time and want to contribute, I think task #18 would be a good fit for you. Since products on an e-commerce website usually have many attributes like name, slug, title, description, images, prices, brand, category, etc., a product may also have many variations. For example, a Dell laptop might come in different colors like black and white, and have varying RAM options like 4GB, 8GB, or 16GB, as well as different disk capacities. Designing a good product structure with all its attributes is always more challenging than it seems. If you're willing to help, you can write documentation in Markdown or create diagrams using draw.io, then push the code to the docs folder in the project. Thank you.

PALASH2201 commented 1 month ago

@khanhduzz I can do the Exception Handling, I just wanted to know how you want it to be implemented. And about the Product structure I will look into it and get back to you with a draft

HiddenCa commented 1 month ago

Hi @PALASH2201, It seems there is an issue with a merge conflict. If you're unsure about how to resolve it, you might want to consider closing this PR, pulling the latest code from the main branch, and then creating a new PR. Thanks!

PALASH2201 commented 1 month ago

@khanhduzz I have added the exception handling as instructed.

khanhduzz commented 1 month ago

Hi @PALASH2201 , I already added some comments, please check it, thank you! Could you explain to me why you move this file? Thanks.

PALASH2201 commented 1 month ago

@khanhduzz I added Sell-bff as a module, so maybe because of that it moved

khanhduzz commented 1 month ago

@PALASH2201 Omg, it's been a hectic day! I'll try to review everything tomorrow when I have more time. Thanks for your patience!

PALASH2201 commented 1 month ago

@khanhduzz No problem, just that its been many days this pr is open thats why wanted to wrap this up

khanhduzz commented 1 month ago

Hi @PALASH2201, I've added some comments—please review them. Thank you so much for your great effort in tackling this issue. I'm looking forward to approving your PR.