search

khanna-lab / cadre

Other
0 stars 0 forks source link

Smoking status in Person constructor #128

Open khanna7 opened 11 months ago

khanna7 commented 11 months ago

https://github.com/khanna-lab/cadre/blob/565627a1cfe380def69163832a3d24031c73fb24/python/pycadre/cadre_person.py#L21C18-L32

I am forgetting why we don't assign the smoking attribute here or in the person creator:

Might this be a good change to make? It could help us when we try to adjust incarceration probabilities by smoking status.

dsheeler commented 11 months ago

Not sure I see how it helps when we try to adjust incarceration probabilities by smoking status... can you explain? But I think it's probably better to person creator pass in the status