khannakshat7 / Elektra

⚡ML powered Electricity Outage prediction⚡
https://elecktra.uc.r.appspot.com
MIT License
41 stars 84 forks source link

Footer #131

Closed shonali2600 closed 3 years ago

shonali2600 commented 3 years ago

Related Issuse

Footer was not looking different from the whole page

Closes: #101

Describe the changes you've made

I've designed the footer, changed the background colour and some of the text colour.

Checklist:

Screenshots

| Original | footer1

| Updated | footer2

shonali2600 commented 3 years ago

@khannakshat7 sir, @CodesbyUnnati ma'am, kindly review my PR and provide me feedback, it's been 7 days now.

CodesbyUnnati commented 3 years ago

image This PR is having conflicts shonali...Pls resolve them:) image Also, Please maintain the color scheme of the website for the footer.

shonali2600 commented 3 years ago

@CodesbyUnnati I've resolved the conflicts, and tried to change its color, but wasn't able to because of the "Elektra" Logo on the left side. I tried to use the blue color(same as Elektra logo) because it matches the theme, but the logo is not visible in that. So can you please suggest me any better color?

shonali2600 commented 3 years ago

@CodesbyUnnati @khannakshat7 Please suggest me changes so that I can work on it and able to make PR. Also my other PR are also pending since long #132 and #158 , Please review that also.

khannakshat7 commented 3 years ago

@shonali2600 can you pl. resolve the conflicts

shonali2600 commented 3 years ago

@khannakshat7 resolved the conflicts

khannakshat7 commented 3 years ago

@shonali2600 Please don't use the beautifier and don't commit settings.py file as it has ur DB credentials

shonali2600 commented 3 years ago

@khannakshat7 I've reverted the commit, now it's fine

khannakshat7 commented 3 years ago

@shonali2600 It is perfect but can u pl. remove the extra space below footer. image

shonali2600 commented 3 years ago

elek

@khannakshat7 done