Closed arpit456jain closed 3 years ago
@CodesbyUnnati @khannakshat7 kindly review my PR and add labels
@arpit456jain I'll review it and merge
@arpit456jain I'll review it and merge
Ok
@arpit456jain I'll review it and merge
@khannakshat7 I hope its working and looking fine
@arpit456jain No need to create a new JS file just add ur code to main.js file
@arpit456jain No need to create a new JS file just add ur code to main.js file
@khannakshat7 moved the js to main.js and deleted showpassword.js
And I had also checked the feature after this and its working fine.
@khannakshat7 please review it I had done the changes you requested
@arpit456jain Buddy u have moved the code to main.js But it is not working. The password is being printed in console but not shown in textbox password.
@arpit456jain Buddy u have moved the code to main.js But it is not working. The password is being printed in console but not shown in textbox password.
@khannakshat7 its working on my local system i had checked it twice try to hard refresh
If its not working can i put the js code in Seperate file ?
Ok do that
On Sun, Apr 18, 2021 at 5:48 PM 111arpit1 @.***> wrote:
If its not working can i put the js code in Seperate file ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/khannakshat7/Elektra/pull/161#issuecomment-821982773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3XXPFTRFPSATTXGJKUX3LTJLEYFANCNFSM42Z27XHA .
Ok do that … On Sun, Apr 18, 2021 at 5:48 PM 111arpit1 @.***> wrote: If its not working can i put the js code in Seperate file ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#161 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3XXPFTRFPSATTXGJKUX3LTJLEYFANCNFSM42Z27XHA .
Give me 5 mins
@khannakshat7 changes done and i am uploading a video for confirmation
Related Issuse
I had added a show password feature to login and signup form
Closes: #156
Describe the changes you've made
https://user-images.githubusercontent.com/55352601/114445489-c46d8b80-9bed-11eb-8ec3-59328d0ca614.mp4
Checklist: