khannakshat7 / Elektra

⚡ML powered Electricity Outage prediction⚡
https://elecktra.uc.r.appspot.com
MIT License
41 stars 84 forks source link

login view update #178

Open sreetu opened 3 years ago

sreetu commented 3 years ago

Related Issuse

Closes: #166 [issue number that will be closed through this PR]

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know! I have added 'requied' tag in the input forms of the login page to make them as madatory field

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot
sreetu commented 3 years ago

I have resolved the branch conflicts which were arising previously. Kindly review now sir @khannakshat7

khannakshat7 commented 3 years ago

@sreetu Please resolve the conflicts

sreetu commented 3 years ago

I have deleted the duplicate code and so, conflict has been resolved.

khannakshat7 commented 3 years ago

@sreetu Any update on this?

sreetu commented 3 years ago

@sreetu Any update on this?

@khannakshat7 sir, I have resolved the conflicts.

arpit456jain commented 3 years ago

I think there is some mistake in this PR have a look

actual after this
arpit456jain commented 3 years ago

this PR is removing one of the most important code on that page @khannakshat7 please look into this

arpit456jain commented 3 years ago

there is a code for error / success msg after the div having id myTabContent but this PR is removing it.

Please allow me to make a PR for this

arpit456jain commented 3 years ago

@khannakshat7 please assign me