khannakshat7 / Elektra

⚡ML powered Electricity Outage prediction⚡
https://elecktra.uc.r.appspot.com
MIT License
41 stars 84 forks source link

Login and Registration Form #75

Closed nikhilkotiya closed 3 years ago

nikhilkotiya commented 3 years ago

Related Issuse

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot
khannakshat7 commented 3 years ago

@nikhilkotiya Awesome work!! But few bugs-

  1. Logout button redirecting to the wrong URL.
  2. Display First Name and Last Name before logout button when user is logged in. (Example: Welcome, Akshat Khanna)
  3. After Signup redirect to log in page.
  4. When password is incorrect show login page with error.
khannakshat7 commented 3 years ago

This is the best contribution till now on this project. Great work buddy🙌🙌

nikhilkotiya commented 3 years ago

This is the best contribution till now on this project. Great work buddy🙌🙌

Thank you sir :)

khannakshat7 commented 3 years ago

Just do the required changes and I'll merge the PR

khannakshat7 commented 3 years ago

Who created the Frontend for it?

nikhilkotiya commented 3 years ago

Who created the Frontend for it?

@sakshi

nikhilkotiya commented 3 years ago

@nikhilkotiya Awesome work!! But few bugs-

  1. Logout button redirecting to the wrong URL.
  2. Display First Name and Last Name before logout button when user is logged in. (Example: Welcome, Akshat Khanna)
  3. After Signup redirect to log in page.
  4. When password is incorrect show login page with error.

Sir bug 2 is in the base.html file but I did not commit this file. what did I do? Error is in line 64 ( user to user.first_name)

khannakshat7 commented 3 years ago

Who created the Frontend for it?

@sakshi

Where is the PR for Front end

khannakshat7 commented 3 years ago

@nikhilkotiya Awesome work!! But few bugs-

  1. Logout button redirecting to the wrong URL.
  2. Display First Name and Last Name before logout button when user is logged in. (Example: Welcome, Akshat Khanna)
  3. After Signup redirect to log in page.
  4. When password is incorrect show login page with error.

Sir bug 2 is in the base.html file but I did not commit this file. what did I do? Error is in line 64 ( user to user.first_name)

Can you can do that in base.html?

nikhilkotiya commented 3 years ago

@khannakshat7 sir can you please merge this branch because I can't take the latest code from master. There is an error when I do git pull origin master(maybe because I forked your project). I make a different Pull of base.html file bug.

nikhilkotiya commented 3 years ago

Who created the Frontend for it?

@sakshi

Where is the PR for Front end

She is not answering

khannakshat7 commented 3 years ago

@nikhilkotiya Awesome contribution dude🙌

khannakshat7 commented 3 years ago

Don't forget to star⭐ the repo and follow me on GitHub

nikhilkotiya commented 3 years ago

@nikhilkotiya Awesome contribution dude🙌

Sry sir due to lack of knowledge in git my work slow

khannakshat7 commented 3 years ago

@nikhilkotiya That's how to learn. No issues keep going!!

nikhilkotiya commented 3 years ago

Screenshot (91) Sir my master branch is now up to date and I just commit base.html file but why all files come when I make a pull