khanshoaib3 / stardew-access

An accessibility mod for Stardew Valley with screen reader and keyboard only support!
GNU General Public License v3.0
65 stars 19 forks source link

Linus tent and player tent conflict in the mountains #288

Open BrailleBennett opened 3 months ago

BrailleBennett commented 3 months ago

If the player places a tent in the mountains, the name of the building is Tent, and the door is Tent Entrance. This matches Linus's tent exactly, meaning that it creates an overlapping case. I believe that all tents should be prepended with the player's name who has placed it, as if you are playing co-op, I would assume two players are both sleeping in tents in the same place, and they will conflict.

ParadoxiKat commented 3 months ago

They don't in fact conflict. Linus' tent isn't a building. The buildings in the buildings category are player-built buildings; buildings that are part of the map like shops or houses or Linus' tent never have had entries in the buildings category. Thus the player's tent in the buildings category is conflicting with nothing (in single player, I will address other players in a moment). As for "tent entrance" it's also not conflicting, though arguably not straight forward. As Linus' tent isn't a building and is it's own separate interior map, the "tent entrance" related to it is a warp point and is thus in the doors category. The player built tent on the other hand does not have a separate interior map. It's "door" is therefore not a warp point; it merely prompts you to go to sleep for the night like the bed. It is accordingly under the interactables category as "tent entrance". So no actual conflict exists here. Having "tent entrance" under both doors and interactables might not be straight forward or intuitive -- but you are able to navigate to and interact with either without issue. While not strictly speaking necessary, renaming the entrance to Linus' tent with his name in the doors category would clear up the confusion at least; leaving "tent entrance" in interactables for the player tent. Unrelated to Linus' tent or the mountain map however is the issue that, in co-op mode, if two players both create tents one will overlap and hide the other. Unfortunately the tents do not retain any ownership information. There's no way for us to check that one tent was built by one player and another by a different player. Tents seem to be communal. The solution to this problem is not specific to this problem; the long discussed plan to allow for selecting from among multiple of the same object in the tracker. Having tent 1 entrance, tent 2 entrance etc. There doesn't seem to be an open ticket for that plan or I'd link it as the blocking solution to this. Since for now the only actual thing we can do to address the minor confusion is renaming Linus' tent entrance, I'll do that and call this closed. Separately, we should have a ticket for the plan to add a way to track oak tree 17 or tent 2.