khanshoaib3 / stardew-access

An accessibility mod for Stardew Valley with screen reader and keyboard only support!
GNU General Public License v3.0
65 stars 19 forks source link

Speak Overlapping Objects With NPCs and Floorings #300

Open Leos-Khai opened 2 months ago

Leos-Khai commented 2 months ago

When you are looking at a animal on a blue grass tile, it read bluegrass rather than the animal.

LucieG0 commented 2 months ago

To expand on this issue, when there is one object on top of another, they counter each other and one is not read. Specifically, when playing in co-op, the tiles that players are stood on are overwritten and masked. (Reported by @BrailleBennett ).

khanshoaib3 commented 2 months ago

@Leos-Khai @LucieG0 To move the blue grass down in priority, we would essentially have to degrade all the terrain features which includes the crops and trees. Which would mean, trees will be invisible as tappers will have priority over them.

And about the players/farmers masking objects, well that is a kind of expected behavior, we optimized the algo by aborting further searches if the tile is recognized. Like we abort searching for crops/doors/objects if an npc is found at a particular tile.

I guess we could make an exception for NPCs but to we need to think of something else if we really want to tackle this "overlapping" issue.

Leos-Khai commented 2 months ago

Can you read multiple if there is layered together? Like maybe it can read sheep on blue grass, or heavy tapper on maple tree. or is that not possible?

khanshoaib3 commented 2 months ago

@Leos-Khai It should be possible, I'll limit this "overlapping" functionality to NPCs and Floorings only though.