search

khaosdoctor / deno-opengraph

Fetches and parses data from website to get their OpenGraph metadata
MIT License
4 stars 2 forks source link

Fetching the title-tag #3

Open jnsprnw opened 2 months ago

jnsprnw commented 2 months ago

Thanks so much for this script!

I know that it is specifically for OpenGraph and Twitter data, but since we also get description and other information that are inside the meta tags, it would only be a small addition to also get the content of the title tag. OpenGraph and Twitter data is still not used everywhere, so title is always a good fallback to have.

It would be nice to add this to have one request that fetches all interesting information.

khaosdoctor commented 2 months ago

Hey @jnsprnw thanks for the comment! We are currently implementing this (and a lot more) on #2, if you think the change is small enough, can you please open a PR just exporting this particular type?

jnsprnw commented 2 months ago

I’ve added a PR with a very small addition.

khaosdoctor commented 1 month ago

Thanks a lot for the PR! I merged it, can you please test it? One thing I'm not sure if it's been added (but I can't test it right now) is if the correct type will be returned with title in it