search

kharazi / qdateconvertor

Other
7 stars 3 forks source link

Bugs in date conversion #1

Open nickaein opened 7 years ago

nickaein commented 7 years ago

This library converts some of Georgian dates to Persian (Jalali) days incorrectly.

For instance, for 2014-04-18 it returns 1394-02-29 which is invalid (it should be 1394-01-29).

I read the implementation of library and there are some concerning bugs like uninitialized variables. I do not recommend this library as it is for production code.

kharazi commented 7 years ago

This repository is an old implementation of date converting algorithm(see here if you know Persian well) and maybe there is errors in algorithm or implementation. feel free to contribute to make it great.

sampad1370 commented 6 years ago

Hi I fix some problem in converting Jalali to Miladi and visa versa. You can use it.

MiladR76 commented 6 years ago

hi . thanks for information about fixed it. but I fixed it about 4 month ago and I write qml version of calendar.

sampad1370 commented 6 years ago

OK,Where is fixed version?

MiladR76 commented 6 years ago

it is not on git hub . I use it