kharchenkolab / numbat

Haplotype-aware CNV analysis from single-cell RNA-seq
https://kharchenkolab.github.io/numbat/
Other
157 stars 22 forks source link

Error because of dplyr version #189

Open KatharinaSchmid opened 1 month ago

KatharinaSchmid commented 1 month ago

Hi,

thanks for developing this nice tool. When I upgraded numbat from version 1.2 to 1.4, I first got an error with one of the datasets (see below). I realized that it was related to the dplyr version. I had dplyr 1.1.0 installed first, after updating it vanished. I wanted to report it, so that you can document it in your DESCRIPTION file for the package that a minimum version of dplyr is required now (probably at least 1.1.1?).

Best regards, Katharina


All cells succeeded
Expanding allelic states..
Error in `inner_join()`:
! `...` must be empty.
✖ Problematic argument:
• relationship = "many-to-many"
Backtrace:
     ▆
  1. ├─numbat::run_numbat(...)
  2. │ └─numbat:::expand_states(exp_post, segs_consensus)
  3. │   └─... %>% ungroup()
  4. ├─dplyr::ungroup(.)
  5. ├─dplyr::mutate(...)
  6. ├─dplyr::rowwise(.)
  7. ├─dplyr::mutate(., seg = paste0(seg, "_", cnv_state), )
  8. ├─dplyr::inner_join(., segs_multi, by = "seg", relationship = "many-to-many")
  9. └─dplyr:::inner_join.data.frame(., segs_multi, by = "seg", relationship = "many-to-many")
 10.   └─rlang::check_dots_empty0(...)
 11.     └─rlang::check_dots_empty(call = call)
 12.       └─rlang:::action_dots(...)
 13.         ├─base (local) try_dots(...)
 14.         └─rlang (local) action(...)
``
teng-gao commented 1 month ago

Fixed. Thanks for reporting this.