Remove unused/outdated functions

kharchenkolab / pagoda2

R package for analyzing and interactively exploring large-scale single-cell RNA-seq datasets

204 stars 47 forks source link

Remove unused/outdated functions #105

Closed evanbiederstedt closed 4 years ago

evanbiederstedt commented 4 years ago

As recommend by @VPetukhov, I took a stab at removing some outdated functions.

I don't see fast.pca() used in helpers.R
The only thing used in dendrogram.R is my.heatmap2
I left everything in cell.sorting.R untouched, as these functions are documented and exported.
I didn't see anything in p1app4p2.R used, so I removed it.

Naturally, I could be making mistakes, so let's triple check this.

evanbiederstedt commented 4 years ago

Based on PK comments, I'm happy to keep p1app4p2.R, if we document things :)

pkharchenko commented 4 years ago

A clarification … what I used is p2.make.pagoda1.app() … I assumed it’s in p1app4p2.r

On Aug 19, 2020, at 11:38, evanbiederstedt notifications@github.com wrote:

Based on PK comments, I'm happy to keep p1app4p2.R, if we document things :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

evanbiederstedt commented 4 years ago

A clarification … what I used is p2.make.pagoda1.app() … I assumed it’s in p1app4p2.r

@pkharchenko It is. I'm happy to back p1app4p2.R, if we document things.