keep.limits triggers error in plotEmbedding

kharchenkolab / pagoda2

R package for analyzing and interactively exploring large-scale single-cell RNA-seq datasets

204 stars 47 forks source link

Closed teng-gao closed 1 year ago

teng-gao commented 1 year ago

In pagoda$plotEmbedding, keep.limits = T is supposedly able to help maintain axis limits while plot.na = F, but it triggers an error:

Error in embedding[, 1]: incorrect number of dimensions

evanbiederstedt commented 1 year ago

Yeah, this is a bug I can reproduce.

I'll fix and update shortly.

evanbiederstedt commented 1 year ago

It's been almost a year. I realistically won't get to this bug any time soon.

It shouldn't be that complicated to fix.

Maybe it's something fun for @rrydbirk or others in his lab/group to fix. @teng-gao might have fun tackling this as well.

I'll put a help wanted ticket here.

rrydbirk commented 1 year ago

Fixed in f65d0d6, I'll create a PR.