Fix connect_response packet

kharidiron / StarryPy

Plugin-driven Starbound proxy server built using Twisted.

Do What The F*ck You Want To Public License

10 stars 3 forks source link

Fix connect_response packet #42

Closed Zwergengraf closed 9 years ago

Zwergengraf commented 9 years ago

reject_with_reason in plugins/core/player_manager/plugin.py is broken, clients with "bad" character names are not rejected - they are online but bypass the wrapper (do not appear in the list of players and so on). Bad stuff.

Possible fix: https://gist.github.com/Zwergengraf/bbaeb39ac5af27bdcbb4

kharidiron commented 9 years ago

KK, thanks for the help. I applied your patch, and it looks like it definitely works for names like ' ' (all spaces). I haven't been able to get accented names to work, since starbound keeps rejecting them before I can log in. May need to borrow someone international to test.