search

kharidiron / StarryPy3k

StarryPy on Python3k
Other
5 stars 3 forks source link

Add IRC chat logging #34

Closed dopeghoti closed 8 years ago

dopeghoti commented 8 years ago

Now we can see both sides of a conversation in the log.

kharidiron commented 8 years ago

Hm... as it stands now, chat logging is not does as a requirement, but as an option (eg - it is its own plugin).

That said, while I think moving this capability into the logging plugin would be pain, I think the capability of logging the chats should be option; as in, some servers may not want chat logs in their server logs. If you can provide a mechanism to toggle this from the plugin config, I'd be a bit happier about merging it.

kharidiron commented 8 years ago

Ok, cool. Pulling in.