search

khartinger / ePaperDisplay_D1mini

examples EPD (waveshare ePaper display) connected to D1 mini
2 stars 0 forks source link

The Wire.endTransmission() should not be used together with Wire.requestFrom(). #1

Closed Koepel closed 6 years ago

Koepel commented 6 years ago

In the file "ePaperDisplay_D1mini/D1_Epd0154bw_BME280_mqtt_sleep/D1_class_BME280.cpp" there is a Wire.endTransmission() after the Wire.requestFrom(). That Wire.endTransmission() can be removed. Explanation: Common-mistakes#2

khartinger commented 6 years ago

Thank you

Koepel commented 6 years ago

When searching Github for the wrong use of the Wire library, your repository came up again. In the file "ePaperDisplay_D1mini/D1_Epd0290bw_mqtt_sleep_Weather1/src/bh1750/D1_class_BH1750.cpp" there is a Wire.endTransmission() after a Wire.requestFrom() and it is still in other files as well.