search

khazhyk / osuapi

Simple osu api wrapper that I can use with both requests and aiohttp
http://osuapi.readthedocs.io/en/latest/index.html
MIT License
16 stars 8 forks source link

Correct the include_converted value #6

Closed Phxntxm closed 7 years ago

Phxntxm commented 7 years ago

As per the OSU API: https://github.com/ppy/osu-api/wiki#parameters

This variable is to be 0 or 1, and with the current version of aiohttp, False cannot be passed here.

khazhyk commented 7 years ago

Casing to int in the call to request might be better e.g., include_converted is still True or False, but then cast to int

int(False) == 0, int(True) == 1

Phxntxm commented 7 years ago

Very true, I can see the use of that, changed it to be a cast