kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
347 stars 27 forks source link

Rework Options Menu #141

Closed kheina closed 1 year ago

kheina commented 1 year ago

as we add more features, especially those that are going to require additional menu options, it's probably going to become necessary to create an advanced options menu or a full options menu rather than putting it all in the context menu. as it is, if you have both popups and threshold enabled, a scrollbar appears.

so, I'd like to propose that:

  1. we remove a few options that currently exist in the context menu and create a new settings page for them
  2. the context menu never becomes so large that the browser creates a scrollbar for it
  3. all current options and any new options are placed in the settings menu

I also think that the options that should stay in the context menu are only those that someone could conceivably want to change multiple times and not "set and forget"

options like:

the rest of the space in the context menu could be used for state or even just left blank

kheina commented 1 year ago

I went for tabs rather than a whole new page for advanced. I thought it looked a lot cleaner this way. it doesn't currently work because all of the options are denoted by ids, and everything in duplicated from basic to advanced, so the second id is ignored by the js image image