Open camjackson opened 1 year ago
hey thanks for all this, this is really good info. yeah it looks like your worker is fine, but you're correct that that is_blue_verified
is what bb is looking for. I'll have a look at this in depth tomorrow and try to see what's up. I might have extra questions or info for you then
I will mention before I go, that you can download logs from your console and paste them as files here. just double check there's no sensitive info in them first
Ok a bit more info. It looks like the issue is that the extension only sees tweets that are loaded after the initial page load. Here are my observations:
[Blue Blocker] queue consumer started
[Blue Blocker] parsed instructions path:
. The two instruction types are:
TimelineAddEntries
TimelineTerminateTimeline
AddEntries
instruction is the 11th reply.So basically the extension doesn't see any users that are already on the page when it loads, which all of the blue users are. The extension only sees the users "below the fold" so to speak, who are all non-blue.
Ok further test results confirm that the problem is due to initial page load vs. tweets fetched after page load.
If I load the tweet by opening up a new tab and navigating directly to the tweet permalink, the behaviour is as described above. If however I am already on twitter and load that tweet via a client-side transition (e.g. click on a link to the tweet from a quote-tweet, from search results, or from the user's profile), then everything works fine.
Maybe the extension was always intended to work this way. I realise it's much easier to sniff XHR payloads than to crawl the DOM. Would be cool if it could do both though!
Gonna rename this issue to be more specific about the actual problem. It's probably a feature request rather than a bug.
I looked into this a little bit earlier and yeah that's the issue. blue blocker does work by xhr hijacking and I think it's just a firefox order of operations thing, since on chrome this isn't an issue, it just means that twitter's frontend was able to send the xhr request before blueblocker was able to bind to the xhr prototype. I have known about this issue for a while but haven't been able to find a fix for it yet.
Ahhhh ok got it. Do you think it would be worth adding like a "known issues" section to the wiki? I could open a PR if you're interested?
it's probably worth making a known issues section yeah. if you know of a fix for this issue on firefox then absolutely make a pr! xhr is modified in the inject script, which is run by the startup content script
occurs to me you meant pr to the wiki, yeah go for it lol I'd just make a new page for it
Browser: Firefox 114.0.2 Extension: v0.3.3
I'm looking at this tweet, and it seems no users are being added to the queue or being blocked as I scroll. The extension says:
Console logs when I load that tweet:
I tried to paste the full JSON contents of those two arrays, but they're too long to fit here. However, I did note that every user (in both arrays) has
"is_blue_verified": false,
despite there being plenty of blue checks in the replies. That seems suspicious?Service worker logs (couple of errors at the bottom but I don't think they're relevant?):