search

kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
326 stars 29 forks source link

Already muted accounts get queued again #198

Closed roland-detterbeck closed 6 months ago

roland-detterbeck commented 11 months ago

Hi,

I use the following setting: "mute users instead of blocking them"

Every time I scroll over a muted users comment, he gets queued again.

And the blocked counter goes +1 - for now the counter says 24k and i muted about 12k users.

Is there a way to optimize this?

Thanks!

kheina commented 11 months ago

I think you've found a bug that's been hidden since this feature was added. blue blocker uses the twitter api's user.legacy.blocking field to determine whether or not to skip this particular user because they've already been blocked

https://github.com/kheina-com/Blue-Blocker/blob/f6db6561f89b8f3c29a9a181b6d81534208eab09/src/shared.ts#L379-L381

however, I don't think we ever added a catch for if the user is using the mute option and the user has already has them muted. in fact, I'm not sure if the twitter api returns this information, though I think it should.

given that the current lord of twitter has deemed blocking should be removed from the platform, fixing this should be prioritized.