search

kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
326 stars 29 forks source link

Turn on CodeQL #223

Closed cooljeanius closed 7 months ago

cooljeanius commented 7 months ago

This PR adds a basic set of automated CodeQL checks for the repo, so that it will be easier to tell if future PRs break anything.

cooljeanius commented 7 months ago

@kheina so even though you added me as a collaborator to this repo, I can't merge this PR, since it requires an approving review, and I can't self-review...

kheina commented 7 months ago

I'm not sure how necessary this is, plus I'm a little wary of running out of the free github worker hours cuz I don't wanna pay for that shit. I'd rather set up something that auto-deploys to the stores on merges to main

kheina commented 7 months ago

@cooljeanius you should be able to merge now, I think

cooljeanius commented 7 months ago

I'm not sure how necessary this is, plus I'm a little wary of running out of the free github worker hours cuz I don't wanna pay for that shit.

I've been using codeql a lot and haven't had to pay for anything yet...

@cooljeanius you should be able to merge now, I think

So I updated this PR so that it includes the codeowners commit, and it automatically requested some additional reviews for me; this is how it looks now:

Screen Shot 2023-12-31 at 19 33 51
kheina commented 7 months ago

I'm not sure how necessary this is, plus I'm a little wary of running out of the free github worker hours cuz I don't wanna pay for that shit.

I've been using codeql a lot and haven't had to pay for anything yet...

@cooljeanius you should be able to merge now, I think

So I updated this PR so that it includes the codeowners commit, and it automatically requested some additional reviews for me; this is how it looks now: Screen Shot 2023-12-31 at 19 33 51

try to review it yourself and see if you can merge then. I don't think I have any setting on to prevent self-approved prs if you're a codeowner

cooljeanius commented 7 months ago

try to review it yourself and see if you can merge then. I don't think I have any setting on to prevent self-approved prs if you're a codeowner

The "approve" button is greyed out:

Screen Shot 2024-01-03 at 02 36 37

(N.B. I use @fregante's "Refined GitHub" browser extension in case that affects anything...)

kheina commented 7 months ago

yeah idk its dumb ig