kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
326 stars 29 forks source link

Add check for tweets that have been edited #244

Closed rougetimelord closed 3 months ago

rougetimelord commented 3 months ago

Changelog

Deployment Checklist

  1. [x] ensure src/manifest.ts and package.json have the correct version number
  2. [ ] use makefile to generate zips (make chrome, make firefox)
    • [x] chrome should be tested with npm run build
    • [ ] test firefox locally using zip
  3. [ ] merge llb to main
  4. [ ] upload zips from 3 to chrome webstore and firefox addons
cooljeanius commented 3 months ago

Does this do anything for #194?

rougetimelord commented 3 months ago

Does this do anything for #194?

I don't think so? It just sets user.is_blue_verified to true but then the following check can override that. https://github.com/kheina-com/Blue-Blocker/blob/2c1e8ea5ea0ea2b7df9d03a6095c49ba15c0d6ff/src/shared.ts#L556-L572

We could add a property to the user object if we detect blue features being used and skip the legacy check if it's true to close #194.

rougetimelord commented 3 months ago

Ok, made it so that the (non)usage of blue features that the extension detects gets reflected in the user object and the legacy DB check is skipped if usage is detected. Probably should add a config option to control that behavior but tbh I really don't like editing the popup code 😭, @cooljeanius if you want to add that it would be much appreciated ❤️

rougetimelord commented 3 months ago

LGTM; haven't tested it myself, but I assume you have?

Gunna test it for a bit longer, and try to get the option added to config before merging :)

rougetimelord commented 3 months ago

Putting this PR on hold while we see how the update removing checkmark hiding plays out.

rougetimelord commented 3 months ago

No more functionality changes, good to go for reviews.

Tested, and looks good on Chrome. I think it's worth merging now, since there is a use for the functionality suggested in #194 even if users can't hide checkmarks anymore.