Closed rougetimelord closed 3 months ago
Does this do anything for #194?
Does this do anything for #194?
I don't think so? It just sets user.is_blue_verified to true but then the following check can override that. https://github.com/kheina-com/Blue-Blocker/blob/2c1e8ea5ea0ea2b7df9d03a6095c49ba15c0d6ff/src/shared.ts#L556-L572
We could add a property to the user object if we detect blue features being used and skip the legacy check if it's true to close #194.
Ok, made it so that the (non)usage of blue features that the extension detects gets reflected in the user object and the legacy DB check is skipped if usage is detected. Probably should add a config option to control that behavior but tbh I really don't like editing the popup code 😭, @cooljeanius if you want to add that it would be much appreciated ❤️
LGTM; haven't tested it myself, but I assume you have?
Gunna test it for a bit longer, and try to get the option added to config before merging :)
Putting this PR on hold while we see how the update removing checkmark hiding plays out.
No more functionality changes, good to go for reviews.
Tested, and looks good on Chrome. I think it's worth merging now, since there is a use for the functionality suggested in #194 even if users can't hide checkmarks anymore.
Changelog
Deployment Checklist
src/manifest.ts
andpackage.json
have the correct version numbermake chrome
,make firefox
)npm run build
3
to chrome webstore and firefox addons