kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
321 stars 28 forks source link

0.4.2 #267

Closed rougetimelord closed 1 month ago

rougetimelord commented 2 months ago

This is a long-lived branch, intended to aggregate all changes planned for version 0.4.2.

Pull requests should be made against this branch. Merges to this branch should be done via a merge commit. When ready, this branch should be merged to main via a squash commit.

Changelog

Deployment Checklist

  1. [x] merge all pull requests to llb
  2. [x] ensure src/manifest.ts and package.json have the correct version number
  3. [ ] use makefile to generate zips (make chrome, make firefox)
    • [x] chrome should be tested with npm run build
    • [ ] test firefox locally using zip
  4. [ ] merge llb to main
kheina commented 1 month ago

I would like to do a full review before we merge anything this large, I'll do that tonight. I also have thoughts on what to do regarding the emoji/words regex which I'll add when I get to that part of the pr.

tonight being ~4-5 hours from now, I'm at work currently

kheina commented 1 month ago

this is what I meant by having a "compiled" config for running on vs saving. this way we're not saving extra data and only compiling once per request https://github.com/kheina-com/Blue-Blocker/pull/283

rougetimelord commented 1 month ago

Going to start testing! Can confirm that with the fixes the extension can queue and block people again

rougetimelord commented 1 month ago

Problems:

MaxIsJoe commented 1 month ago

Problems:

  • [ ] Empty disallowed words list seems to spam block everything

image

I added this check specifically to address this issue in my original PR.

rougetimelord commented 1 month ago

Problems:

  • [ ] Empty disallowed words list seems to spam block everything

image

I added this check specifically to address this issue in my original PR.

Yea, but then we switched to precompiling the regex, so I'll futz around with it

rougetimelord commented 1 month ago

Ok that's all the bugs I've found so far squashed. Going to keep testing for tonight to see if something pops up, but I think we're close to being able to merge.

kheina commented 1 month ago

I'll do another review and some testing tonight after work. hopefully it can go out tonight

kheina commented 1 month ago

I'll do another review and some testing tonight after work. hopefully it can go out tonight

I'll probably also just push a bunch of styling changes/fixes since I'm pretty particular about the appearance of the popup menu

rougetimelord commented 1 month ago

I'll do another review and some testing tonight after work. hopefully it can go out tonight

I'll probably also just push a bunch of styling changes/fixes since I'm pretty particular about the appearance of the popup menu

Go ham! I think having the setting be hidden behind a checkbox if not enabled would make a lot of sense in terms of not cluttering up the interface, kinda like what the skip threshold setting does

kheina commented 1 month ago

I'll do another review and some testing tonight after work. hopefully it can go out tonight

I'll probably also just push a bunch of styling changes/fixes since I'm pretty particular about the appearance of the popup menu

Go ham! I think having the setting be hidden behind a checkbox if not enabled would make a lot of sense in terms of not cluttering up the interface, kinda like what the skip threshold setting does

I went ham

rougetimelord commented 1 month ago

One approval pls 👉🏻👈🏻