kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
349 stars 27 forks source link

Unify manifest.json #270

Open rougetimelord opened 6 months ago

rougetimelord commented 6 months ago

It would be nice to have a single manifest.json file for Firefox and Chrome. We could do this by migrating Firefox to MV3.

The main issue is how we load our service worker or background script (for Firefox). According to MDN:

We would also still need to add browser_specific_settings for Firefox. Due to that we could keep the background.service_worker key replacement in our build process, to make sure that Firefox <121 is supported.

In terms of code changes according to Mozilla's extension tester, the only change needed would be to remove chrome.runtime.restartAfterDelay from src/constants.ts. I think that's fine since we don't ever use it, and it should probably be removed anyways.

kheina commented 6 months ago

https://github.com/kheina-com/Blue-Blocker/issues/39#issue-1689806775

rougetimelord commented 6 months ago

Oh Mozilla/Google, very nice of you to make everything complicated and hard to support cross browsers!

Seems like Firefox 102ESR is past EOL (9/26/2023), and Firefox 115.2.0ESR released in August 2023 which afaik means that (most) ESR installations should support Mv3.