search

kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
321 stars 28 forks source link

[feat] adds the option to skip blue checkmark users #278

Closed MaxIsJoe closed 1 month ago

MaxIsJoe commented 2 months ago

closes #166

Adds the ability to skip over blue checkmark users because some users might want to only use this extension to block ads or offensive users, but not block every blue checkmark user out there.

Changelog

Summary
    1. document grouping follow 'SemVer2.0' protocol
    2. use 'PATCH' as a minimum granularity
    3. use concise descriptions
    4. type: feat \ fix \ update \ perf \ remove \ docs \ chore
    5. version timestamp follow the yyyy.MM.dd format

Deployment Checklist

  1. [ ] merge all pull requests to llb
  2. [ ] ensure src/manifest.ts and package.json have the correct version number
  3. [ ] use makefile to generate zips (make chrome, make firefox)
    • [X] chrome should be tested with npm run build
    • [ ] test firefox locally using zip
  4. [ ] merge llb to main
  5. [ ] upload zips from 3 to chrome webstore and firefox addons
MaxIsJoe commented 2 months ago

out of scope of this PR, but once 0.4.2 is out; I'm considering cleaning up shared.ts as some functions are a bit too monolithic. BlockBlueVerified() alone is 230+ lines long, and that's without including the changes in #275

cooljeanius commented 2 months ago

eh... idk, I personally think it would be better to keep the extension focused on just what's in its name, but I guess that's not really my decision to make; I'll defer to @kheina on this...

rougetimelord commented 2 months ago

eh... idk, I personally think it would be better to keep the extension focused on just what's in its name, but I guess that's not really my decision to make; I'll defer to @kheina on this...

I don't think it's a super out of place addition, we're already on the path of letting other extensions implement their own logic for who to block and letting users decide not to block people.

rougetimelord commented 2 months ago

out of scope of this PR, but once 0.4.2 is out; I'm considering cleaning up shared.ts as some functions are a bit too monolithic. BlockBlueVerified() alone is 230+ lines long, and that's without including the changes in #275

PLEASE!! Ideally we wouldn't even need shared.ts and would move all of the logic either into background.ts or content.ts

rougetimelord commented 2 months ago

Ninja'd on that merge lmfao

rougetimelord commented 1 month ago

Review now or forever hold your peace! (I wanna get 0.4.2 out the door 😭 )